WordPress.org
Get WordPress

Make WordPress Core

Opened 19 months ago

Closed 19 months ago

Last modified 19 months ago

#58686 closed defect (bug) (fixed)

Fix docBlock of image_get_intermediate_size()

Reported by: crstauf's profile crstauf Owned by: audrasjb's profile audrasjb
Milestone: 6.3 Priority: normal
Severity: normal Version:
Component: Media Keywords: has-patch commit
Focuses: docs Cc:

Description

Description of returned values in array is incorrect for image_get_intermediate_size():

  • file: returns the filename of image, no path information
  • path: returns path relative to the uploads directory, not absolute

Change History (8)

This ticket was mentioned in ​PR #4770 on ​WordPress/wordpress-develop by ​@crstauf.
19 months ago #1

  • Keywords has-patch added

Description of returned values in array is incorrect for image_get_intermediate_size():

  • file: returns the filename of image, no path information
  • path: returns path relative to the uploads directory, not absolute

Trac ticket: https://core.trac.wordpress.org/ticket/58686

#2 @audrasjb
19 months ago

  • Component changed from General to Media
  • Focuses docs added
  • Keywords commit added
  • Milestone changed from Awaiting Review to 6.3
  • Owner set to audrasjb
  • Status changed from new to accepted

Thanks for spotting this and for the PR!
Moving to 6.3.

#3 @crstauf
19 months ago

Reported by @sccr410 in User Contributed Notes.

Last edited 19 months ago by crstauf (previous) (diff)

#4 follow-up: @audrasjb
19 months ago

@crstauf please don't forget to mention the reporter when moving User Contributed Notes to Trac 🙂
Props: @sccr410.

#5 @audrasjb
19 months ago

ahah, I jumped the gun! 😃
Thanks @crstauf ✌️

#6 in reply to: ↑ 4 @crstauf
19 months ago

Replying to audrasjb:

@crstauf please don't forget to mention the reporter when moving User Contributed Notes to Trac 🙂
Props: @sccr410.

Yep, just realized I should probably do that. See previous comment.

#7 @audrasjb
19 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 56122:

Docs: Fix image_get_intermediate_size() docblock.

The description of returned values in array was incorrect for image_get_intermediate_size():

  • $file returns the filename of image, no path information
  • $path returns path relative to the uploads directory, not absolute

Props crstauf, sccr410.
Fixes #58686.
See #57840.

Note: See TracTickets for help on using tickets.