Make WordPress Core

Opened 8 months ago

Closed 8 months ago

#58702 closed defect (bug) (fixed)

Twenty Twenty-One: Replace the experimental link color theme support

Reported by: poena's profile poena Owned by: audrasjb's profile audrasjb
Milestone: 6.3 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch has-testing-info has-screenshots
Focuses: Cc:

Description

In functions.php, replace add_theme_support( 'experimental-link-color' );
with add_theme_support( 'link-color' );

I am listing this as bug because add_theme_support( 'experimental-link-color' ); will throw a "doing it wrong" message when Gutenberg version 16.2 (currently in development) is active.
The message is intentionally in the Gutenberg plugin, not core, because 'experimental-link-color' was introduced in Gutenberg, and core support was limited.

Follow up to https://core.trac.wordpress.org/ticket/58597.

Attachments (3)

58702.diff (680 bytes) - added by poena 8 months ago.
Replaces the experimental theme support and adds the new link color theme support
58702-2.diff (598 bytes) - added by poena 8 months ago.
Removes the experimental theme support without replacement
Capture d’écran 2023-07-09 à 16.22.31.png (246.4 KB) - added by audrasjb 8 months ago.
After applying 58702.diff

Download all attachments as: .zip

Change History (8)

@poena
8 months ago

Replaces the experimental theme support and adds the new link color theme support

@poena
8 months ago

Removes the experimental theme support without replacement

#1 @poena
8 months ago

  • Keywords has-patch added

I have uploaded two patches. The second option removes the theme support to prevent the doing it wrong message, but does not add the new theme support. This second option would give contributors more time to test and fix any CSS issues related to the link color theme support.

Testing instructions

To reproduce the warning, you need Gutenberg version 16.2 or newer, downloadable from https://github.com/WordPress/gutenberg/

Activate the plugin and the theme and visit the WordPress admin area.

This ticket was mentioned in Slack in #core by mukeshpanchal27. View the logs.


8 months ago

#3 @mukesh27
8 months ago

  • Keywords needs-testing has-testing-info added

This ticket was discussed during the bug scrub.

Manual testing is required for this task. Please ping @ironprogrammer and @webtechpooja to coordinate and perform the necessary tests.

@audrasjb
8 months ago

After applying 58702.diff

#4 @audrasjb
8 months ago

  • Keywords has-screenshots added; needs-testing removed
  • Owner set to audrasjb
  • Status changed from new to accepted

58702.diff is the best option as it also introduces the feature for TT1.
Let's implement this patch :)

#5 @audrasjb
8 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 56170:

Twenty Twenty-One: Replace the experimental link color theme support.

This replaces add_theme_support( 'experimental-link-color' ) with add_theme_support( 'link-color' ), to provide the feature to Twenty Twenty-One users, but
also to avoid throwing a "doing it wrong" message when Gutenberg version 16.2 is active.

Follow-up to [58597].

Props poena.
Fixes #58702.

Note: See TracTickets for help on using tickets.