WordPress.org
Get WordPress

Make WordPress Core

Opened 23 months ago

Closed 23 months ago

#58713 closed defect (bug) (fixed)

Backport: Update default templates info

Reported by: ntsekouras's profile ntsekouras Owned by: isabel_brison's profile isabel_brison
Milestone: 6.3 Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-unit-tests
Focuses: Cc:

Description (last modified by ntsekouras)

We need to backport the recent changes from Gutenberg PRs: ​https://github.com/WordPress/gutenberg/pull/51428 and ​https://github.com/WordPress/gutenberg/pull/52048

Attachments (1)

58713.diff​ (1.3 KB) - added by SergeyBiryukov 23 months ago.

Download all attachments as: .zip

Change History (11)

This ticket was mentioned in ​PR #4793 on ​WordPress/wordpress-develop by ​@ntsekouras.
23 months ago #1

  • Keywords has-patch has-unit-tests added

Trac ticket: https://core.trac.wordpress.org/ticket/58713

This PR back ports the changes from this Gutenberg PR: ​https://github.com/WordPress/gutenberg/pull/51428

#2 @ntsekouras
23 months ago

  • Description modified (diff)

#3 @isabel_brison
23 months ago

  • Owner set to isabel_brison
  • Resolution set to fixed
  • Status changed from new to closed

In 56145:

Editor: update template titles in browse mode.

Adds more meaningful titles to templates in the browse mode template list.

Props ntsekouras, audrasjb.
Fixes #58713.

​@isabel_brison commented on ​PR #4793:
23 months ago #4

Committed in r56145 / ​9d141e5.

#5 @kebbet
23 months ago

  • Keywords needs-patch added; has-patch removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

The description for Author archives was updated in [56145] to :
Displays a single author\'s post archive. This template will serve as a fallback when a more a specific template (e.g., Author: Admin) cannot be found.

That seems to be incorrect, and should be something like this:
Displays a single author\'s post archive. This template will serve as a fallback when a more specific template (e.g., Author: Admin) cannot be found.

#6 @audrasjb
23 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Fixed by [56182] (forgot to fix the ticket directly in the commit).

#7 @audrasjb
23 months ago

  • Keywords needs-patch removed
  • Milestone changed from Awaiting Review to 6.3

@SergeyBiryukov
23 months ago

#8 @SergeyBiryukov
23 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Thanks for the commits!

It appears that there is now a minor inconsistency in the descriptions:

  • Single Entries: Displays any single entry, such as a post or a page. This template will serve as a fallback when a more specific template (e.g., Single Post, Page, or Attachment) cannot be found.
  • Author Archives: This template will serve as a fallback when a more specific template (e.g., Author: Admin) cannot be found.
  • Category Archives: Displays a post category archive. This template will serve as a fallback when more specific template (e.g., Category: Recipes) cannot be found.
  • Tag Archives: Displays a post tag archive. This template will serve as a fallback when more specific template (e.g., Tag: Pizza) cannot be found.

Note the lack of the "a" article in the latter two strings. It should probably be reinstated, see 58713.diff​.

This ticket was mentioned in ​Slack in #core by oglekler. ​View the logs.
23 months ago

#10 @isabel_brison
23 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 56230:

Editor: fix typos in templates info.

Fixes two small typos in wp-includes/block-template-utils.php.

Props SergeyBiryukov.
Fixes #58713.

Note: See TracTickets for help on using tickets.