Make WordPress Core

Opened 3 years ago

Closed 2 months ago

Last modified 2 months ago

#58715 closed defect (bug) (fixed)

WP Themes: Improve various globals documentation.

Reported by: upadalavipul Owned by: SergeyBiryukov
Priority: normal Milestone: 7.1
Component: Bundled Theme Version:
Severity: normal Keywords: has-patch dev-feedback
Cc: Focuses: docs

Description

I have reviewed the code and found some of the files need to be improved comment code. Please check the below files.

File Name:

  • wp-content/themes/twentysixteen/functions.php
  • wp-content/themes/twentytwelve/functions.php
  • wp-content/themes/twentytwenty/functions.php

Attachments (3)

58715.patch (3.0 KB ) - added by upadalavipul 3 years ago.
58715.2.patch (2.1 KB ) - added by upadalavipul 3 years ago.
few more files in need improvement.
58715.3.patch (954 bytes ) - added by upadalavipul 3 years ago.
new patch added

Download all attachments as: .zip

Change History (24)

@upadalavipul
3 years ago

@upadalavipul
3 years ago

few more files in need improvement.

This ticket was mentioned in PR #5920 on WordPress/wordpress-develop by @sabernhardt.


3 years ago
#1

Adds documentation for global variables in all of the classic bundled themes.

Props upadalavipul, shailu25, rajinsharwar, audrasjb, viralsampat

Trac 58715

#2 @sabernhardt
3 years ago

#58606 was marked as a duplicate.

#3 @sabernhardt
3 years ago

#59101 was marked as a duplicate.

#4 @sabernhardt
3 years ago

#60224 was marked as a duplicate.

@upadalavipul
3 years ago

new patch added

#5 @sabernhardt
2 years ago

  • Keywords dev-feedback added
  • Milestone Awaiting ReviewFuture Release

I left some questions on PR 5920, requesting guidance in certain situations.

Last edited 6 months ago by sabernhardt (previous) (diff)

#6 @sabernhardt
12 months ago

#63795 was marked as a duplicate.

#7 @sabernhardt
12 months ago

#63889 was marked as a duplicate.

#8 @sabernhardt
6 months ago

  • Milestone Future Release7.0

#9 @sabernhardt
5 months ago

  • Milestone 7.07.1

It is late in the cycle for this, but I would appreciate a committer taking ownership to review all the suggested changes for 7.1.

#10 @SergeyBiryukov
3 months ago

In 62438:

Twenty Ten: Add missing documentation for some global variables.

Props sabernhardt, upadalavipul, shailu25, rajinsharwar, audrasjb, viralsampat, noruzzaman, huzaifaalmesbah, SergeyBiryukov.
See #58715.

#11 @SergeyBiryukov
2 months ago

In 62442:

Twenty Eleven: Add missing documentation for some global variables.

Props sabernhardt, upadalavipul, shailu25, rajinsharwar, audrasjb, viralsampat, noruzzaman, huzaifaalmesbah, SergeyBiryukov.
See #58715.

#12 @SergeyBiryukov
2 months ago

In 62451:

Twenty Twelve: Add missing documentation for some global variables.

Props sabernhardt, upadalavipul, shailu25, rajinsharwar, audrasjb, viralsampat, noruzzaman, huzaifaalmesbah, SergeyBiryukov.
See #58715.

#13 @SergeyBiryukov
2 months ago

In 62456:

Twenty Thirteen: Add missing documentation for some global variables.

Props sabernhardt, upadalavipul, shailu25, rajinsharwar, audrasjb, viralsampat, noruzzaman, huzaifaalmesbah, SergeyBiryukov.
See #58715.

#14 @SergeyBiryukov
2 months ago

In 62465:

Twenty Fourteen: Add missing documentation for some global variables.

Props sabernhardt, upadalavipul, shailu25, rajinsharwar, audrasjb, viralsampat, noruzzaman, huzaifaalmesbah, SergeyBiryukov.
See #58715.

#15 @SergeyBiryukov
2 months ago

In 62468:

Twenty Fifteen: Add missing documentation for some global variables.

Props sabernhardt, upadalavipul, shailu25, rajinsharwar, audrasjb, viralsampat, noruzzaman, huzaifaalmesbah, SergeyBiryukov.
See #58715.

#16 @SergeyBiryukov
2 months ago

In 62471:

Twenty Sixteen: Add missing documentation for some global variables.

Props sabernhardt, upadalavipul, shailu25, rajinsharwar, audrasjb, viralsampat, noruzzaman, huzaifaalmesbah, SergeyBiryukov.
See #58715.

#17 @SergeyBiryukov
2 months ago

In 62472:

Twenty Seventeen: Add missing documentation for some global variables.

Props sabernhardt, upadalavipul, shailu25, rajinsharwar, audrasjb, viralsampat, noruzzaman, huzaifaalmesbah, SergeyBiryukov.
See #58715.

#18 @SergeyBiryukov
2 months ago

In 62473:

Twenty Nineteen: Add missing documentation for some global variables.

Props sabernhardt, upadalavipul, shailu25, rajinsharwar, audrasjb, viralsampat, noruzzaman, huzaifaalmesbah, SergeyBiryukov.
See #58715.

#19 @SergeyBiryukov
2 months ago

In 62479:

Twenty Twenty: Add missing documentation for some global variables.

Props sabernhardt, upadalavipul, shailu25, rajinsharwar, audrasjb, viralsampat, noruzzaman, huzaifaalmesbah, SergeyBiryukov.
See #58715.

#20 @SergeyBiryukov
2 months ago

  • Owner set to SergeyBiryukov
  • Resolutionfixed
  • Status newclosed

In 62483:

Twenty Twenty-One: Add missing documentation for some global variables.

Props sabernhardt, upadalavipul, shailu25, rajinsharwar, audrasjb, viralsampat, noruzzaman, huzaifaalmesbah, SergeyBiryukov.
Fixes #58715.

@sabernhardt commented on PR #5920:


2 months ago
#21

Commits:

Note: See TracTickets for help on using tickets.