WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Last modified 17 hours ago

#58715 new defect (bug)

WP Themes: Improve various globals documentation.

Reported by: upadalavipul's profile upadalavipul Owned by:
Milestone: 7.1 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch dev-feedback
Focuses: docs Cc:

Description

I have reviewed the code and found some of the files need to be improved comment code. Please check the below files.

File Name:

  • wp-content/themes/twentysixteen/functions.php
  • wp-content/themes/twentytwelve/functions.php
  • wp-content/themes/twentytwenty/functions.php

Attachments (3)

58715.patch​ (3.0 KB) - added by upadalavipul 3 years ago.
58715.2.patch​ (2.1 KB) - added by upadalavipul 3 years ago.
few more files in need improvement.
58715.3.patch​ (954 bytes) - added by upadalavipul 2 years ago.
new patch added

Download all attachments as: .zip

Change History (18)

@upadalavipul
3 years ago

@upadalavipul
3 years ago

few more files in need improvement.

This ticket was mentioned in ​PR #5920 on ​WordPress/wordpress-develop by ​@sabernhardt.
2 years ago #1

Adds documentation for global variables in all of the classic bundled themes.

Props upadalavipul, shailu25, rajinsharwar, audrasjb, viralsampat

Trac 58715

#2 @sabernhardt
2 years ago

#58606 was marked as a duplicate.

#3 @sabernhardt
2 years ago

#59101 was marked as a duplicate.

#4 @sabernhardt
2 years ago

#60224 was marked as a duplicate.

@upadalavipul
2 years ago

new patch added

#5 @sabernhardt
23 months ago

  • Keywords dev-feedback added
  • Milestone changed from Awaiting Review to Future Release

I left some questions on PR 5920 for guidance in certain situations.

Version 0, edited 23 months ago by sabernhardt (next)

#6 @sabernhardt
10 months ago

#63795 was marked as a duplicate.

#7 @sabernhardt
9 months ago

#63889 was marked as a duplicate.

#8 @sabernhardt
4 months ago

  • Milestone changed from Future Release to 7.0

#9 @sabernhardt
3 months ago

  • Milestone changed from 7.0 to 7.1

It is late in the cycle for this, but I would appreciate a committer taking ownership to review all the suggested changes for 7.1.

#10 @SergeyBiryukov
6 days ago

In 62438:

Twenty Ten: Add missing documentation for some global variables.

Props sabernhardt, upadalavipul, shailu25, rajinsharwar, audrasjb, viralsampat, noruzzaman, huzaifaalmesbah, SergeyBiryukov.
See #58715.

#11 @SergeyBiryukov
5 days ago

In 62442:

Twenty Eleven: Add missing documentation for some global variables.

Props sabernhardt, upadalavipul, shailu25, rajinsharwar, audrasjb, viralsampat, noruzzaman, huzaifaalmesbah, SergeyBiryukov.
See #58715.

#12 @SergeyBiryukov
4 days ago

In 62451:

Twenty Twelve: Add missing documentation for some global variables.

Props sabernhardt, upadalavipul, shailu25, rajinsharwar, audrasjb, viralsampat, noruzzaman, huzaifaalmesbah, SergeyBiryukov.
See #58715.

#13 @SergeyBiryukov
3 days ago

In 62456:

Twenty Thirteen: Add missing documentation for some global variables.

Props sabernhardt, upadalavipul, shailu25, rajinsharwar, audrasjb, viralsampat, noruzzaman, huzaifaalmesbah, SergeyBiryukov.
See #58715.

#14 @SergeyBiryukov
40 hours ago

In 62465:

Twenty Fourteen: Add missing documentation for some global variables.

Props sabernhardt, upadalavipul, shailu25, rajinsharwar, audrasjb, viralsampat, noruzzaman, huzaifaalmesbah, SergeyBiryukov.
See #58715.

#15 @SergeyBiryukov
17 hours ago

In 62468:

Twenty Fifteen: Add missing documentation for some global variables.

Props sabernhardt, upadalavipul, shailu25, rajinsharwar, audrasjb, viralsampat, noruzzaman, huzaifaalmesbah, SergeyBiryukov.
See #58715.

Note: See TracTickets for help on using tickets.