WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Last modified 3 years ago

#58752 assigned enhancement

Doc typo improvement to of file : wordpress-develop/src/js/media/views/view.js

Reported by: hasanazizul Owned by:
Priority: normal Milestone: Awaiting Review
Component: Media Version:
Severity: normal Keywords: has-patch 2nd-opinion
Cc: Focuses: docs

Description

There is a grammar error on line 11 of the file like

actual sentence: outside of the media manager.
correct sentence: outside the media manager.

Attachments (1)

58752.diff​ (441 bytes ) - added by sabernhardt 3 years ago.
removing "of" in view.js

Download all attachments as: .zip

Change History (5)

#1 @audrasjb
3 years ago

  • Keywords needs-docs removed

This ticket was mentioned in ​PR #4814 on ​WordPress/wordpress-develop by ​@azizulhasan.
3 years ago #2

  • Keywords has-patch added

…ia/views/view.js.

Doc typo improvement to of file: wordpress-develop/src/js/media/views/view.js

There is a grammar error on line 11 of the file like.

actual sentence: outside of the media manager.
correct sentence: outside the media manager.

Trac ticket: 58752

#3 @SergeyBiryukov
3 years ago

  • Component General → Media

@sabernhardt
3 years ago

removing "of" in view.js

#4 @sabernhardt
3 years ago

  • Keywords 2nd-opinion added

Technically "outside of" is acceptable, at least in North America.
​https://english.stackexchange.com/questions/9700/outside-or-outside-of

If editing view.js, it may be appropriate to edit in other places too.
​https://github.com/search?q=repo%3AWordPress%2Fwordpress-develop+%22outside+of%22&type=code
(Those results include some external libraries.)

Note: See TracTickets for help on using tickets.