Performance issue has_content method in WP_Widget_Media_Gallery

[spacedmonkey]

The has_content method in WP_Widget_Media_Gallery, does not prime post caches before calling get_post_type. Call _prime_post_caches before foreach loop would improve performance.

Trac Ticke

• PR used to add the _prime_post_caches( $attachments ); to cache the posts before iterate to enhance performance.

[niravsherasiya7707]

Hello @spacedmonkey, I have a concern regarding the GitHub action "End-to-end Tests / E2E Tests with SCRIPT_DEBUG enabled/disable." I noticed that this action passes successfully on my pull request (PR), which is against my forked branch. However, when I submitted the same PR to the WordPress Trunk, it failed. I would appreciate any insights or guidance you can provide to help resolve this matter.

[swissspidy]

@niravsherasiya7707 This is a known issue in trunk right now, nothing to do with your PR. Feel free to ignore.

[oglekler]

@spacedmonkey are you satisfied with this patch? How can can proceed? If nesting is the next step, we need an instruction.

[spacedmonkey]

I have some feedback here ​https://github.com/WordPress/wordpress-develop/pull/4819/files#r1309009821.

Once committed, I will test and commit to core.

[niravsherasiya7707]

@spacedmonkey Requested changes are done, please go ahead for next step. Thanks

[mukesh27]

Thank you, @niravsherasiya7707, for updating the PR. With sufficient approvals, I am mark it for the final commit.

[spacedmonkey]

In 56512:

Widgets: Improve performance of has_content method in WP_Widget_Media_Gallery class.

In the method WP_Widget_Media_Gallery::has_content call _prime_post_caches before the foreach loop. This ensures that the post objects are primed in memory before trying to access the post object in get_post_type.

Props niravsherasiya7707, spacedmonkey, mukesh27.
Fixes #58757.