Make WordPress Core

Opened 9 months ago

Closed 9 months ago

Last modified 9 months ago

#58766 closed defect (bug) (fixed)

Twenty Twenty-Three: height of featured images causes expanding iFrame when viewing style variations

Reported by: mikachan's profile mikachan Owned by: isabel_brison's profile isabel_brison
Milestone: 6.3 Priority: normal
Severity: normal Version: 6.3
Component: Bundled Theme Keywords: has-patch
Focuses: css Cc:

Description

In Twenty Twenty-Three, the height of the featured images in the Archive, Home, Index, and Search templates is currently set to max(15vw, 30vh). When viewing the style variations in the editor, this causes an ever-expanding view in the iFrame used to preview the style variations.

Please see this Gutenberg issue for more information and videos: https://github.com/WordPress/gutenberg/issues/52297

We can prevent this by setting a fixed maximum height for the featured images.

Change History (9)

This ticket was mentioned in PR #4821 on WordPress/wordpress-develop by @mikachan.


9 months ago
#1

  • Keywords has-patch added

This sets the height of the featured images in the Archive, Home, Index, and Search templates from max(15vw, 30vh) to clamp(15vw, 30vh, 400px). This is to set a maximum fixed-pixel height on the featured images, to prevent them from causing an ever-expanding iFrame height. Please see https://github.com/WordPress/gutenberg/issues/52297 for more details.

Before After
https://i0.wp.com/github.com/WordPress/wordpress-develop/assets/1645628/c5323db2-3ee8-4331-9dd7-0d4d9e60a227 https://i0.wp.com/github.com/WordPress/wordpress-develop/assets/1645628/ee0f5828-fefd-4743-8331-4406e8c9e47c

Trac ticket: https://core.trac.wordpress.org/ticket/58766

This ticket was mentioned in PR #4821 on WordPress/wordpress-develop by @mikachan.


9 months ago
#2

This sets the height of the featured images in the Archive, Home, Index, and Search templates from max(15vw, 30vh) to clamp(15vw, 30vh, 400px). This is to set a maximum fixed-pixel height on the featured images, to prevent them from causing an ever-expanding iFrame height. Please see https://github.com/WordPress/gutenberg/issues/52297 for more details.

Before After
https://i0.wp.com/github.com/WordPress/wordpress-develop/assets/1645628/c5323db2-3ee8-4331-9dd7-0d4d9e60a227 https://i0.wp.com/github.com/WordPress/wordpress-develop/assets/1645628/ee0f5828-fefd-4743-8331-4406e8c9e47c

Trac ticket: https://core.trac.wordpress.org/ticket/58766

annezazu commented on PR #4821:


9 months ago
#3

Noting that we can ideally get this in before the Product Demo on July 27th as we'll use the TT3 theme then.

#4 @mikachan
9 months ago

  • Keywords needs-testing added

@ramonopoly commented on PR #4821:


9 months ago
#5

Thanks a lot @mikachan LGTM

Here are some huge GIFs 🎉

## Before
https://i0.wp.com/github.com/WordPress/wordpress-develop/assets/6458278/5720c9fb-d746-4646-9499-0e25baa96fac

## After
https://i0.wp.com/github.com/WordPress/wordpress-develop/assets/6458278/86175e6b-3245-4b53-b856-2c958dfd4f1c

#6 @isabel_brison
9 months ago

  • Owner set to isabel_brison
  • Resolution set to fixed
  • Status changed from new to closed

In 56207:

Bundled Theme: fix height of featured images in Twenty Twenty Three.

Fixes max height of the featured images in the Archive, Home, Index, and Search templates to prevent expanding iframe bug.

Props mikachan, ramonopoly.
Fixes #58766.

@isabel_brison commented on PR #4821:


9 months ago
#7

Committed in r56207 / 4e864a1.

#8 @kebbet
9 months ago

Please set milestone to 6.3 for visibility @isabel_brison. Thanks!

#9 @sabernhardt
9 months ago

  • Keywords needs-testing removed
  • Milestone changed from Awaiting Review to 6.3
Note: See TracTickets for help on using tickets.