Make WordPress Core

Opened 8 months ago

Closed 6 months ago

#58785 closed enhancement (fixed)

Show dashicons-dismiss instead of the character 'x' when we talk about the dashicon-dismiss

Reported by: presskopp's profile Presskopp Owned by: joedolson's profile joedolson
Milestone: 6.4 Priority: normal
Severity: normal Version: 3.0
Component: Help/About Keywords: has-screenshots has-patch commit
Focuses: accessibility, ui-copy Cc:

Description

The help text on the bulk edit screen explains to click the x next to the name to remove the entry from the bulk edit list. But the x is in fact a dashicon. So why not show the dashicon?

See https://build.trac.wordpress.org/browser/trunk/wp-admin/edit.php?marks=291#L291

Remarks:

When patching to

/* translators: %s is the 'x' icon */
    __( 'When using Bulk Edit, you can change the metadata (categories, author, etc.) for all selected posts at once. To remove a post from the grouping, just click the %s next to its name in the Bulk Edit area that appears.' ),
    '<span class="dashicons dashicons-dismiss"></span>'
    ) . '</p>',

the dashicon would be shown too big. It should get

style="font: normal 16px/20px dashicons;"

somehow to make it fit the size the list icons are

Attachments (3)

x.png (46.5 KB) - added by Presskopp 8 months ago.
dash.png (51.4 KB) - added by Presskopp 8 months ago.
58785.diff (1.2 KB) - added by sabernhardt 8 months ago.
adding dashicon with aria-hidden and including the word "button" in the text

Download all attachments as: .zip

Change History (17)

@Presskopp
8 months ago

@Presskopp
8 months ago

#1 @Presskopp
8 months ago

  • Keywords has-screenshots added

#2 @Presskopp
8 months ago

  • Severity changed from normal to minor

#3 @costdev
8 months ago

  • Focuses accessibility added

This might be a good time to address accessibility here. Whether using "x" or the dashicon, the screenreader text for the button doesn't mention "x", so both options are somewhat reliant on sight, or at least require the user to make an educated guess.

Adding accessibility so folks with more experience can weigh in with their thoughts on whether this is an accessibility concern, and if so, how best to improve accessibility here.

Last edited 8 months ago by costdev (previous) (diff)

@sabernhardt
8 months ago

adding dashicon with aria-hidden and including the word "button" in the text

#4 @sabernhardt
8 months ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 6.4
  • Severity changed from minor to normal
  • Version set to 3.0

The patch is a quick draft (possible PHPCS issues).

This help text sentence could mention that the icon is a button.

Version 3.0: the string was edited in [19511], but the X was in the original help text from [14855].

#5 @mikinc860
8 months ago

Good catch, This can be more significant to identify the exact message.

This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.


7 months ago

#7 @joedolson
7 months ago

The actual name of the button in the bulk edit panel is "Remove {post name} from bulk edit". I think it would appropriate for the dashicon in the help text to be announced as "remove" for screen readers, since that's the common stem of the button name that they'll observe.

#8 @oglekler
6 months ago

  • Keywords changes-requested added

I think @joedolson has a good point and the name of the button can be added to its symbol.

This ticket was mentioned in Slack in #core by oglekler. View the logs.


6 months ago

This ticket was mentioned in PR #5070 on WordPress/wordpress-develop by matthewfarlymn.


6 months ago
#10

Added screen reader text "remove" to accompany bulk edit help text icon

Trac ticket: [](https://core.trac.wordpress.org/ticket/58785)

#11 @bvreeman22
6 months ago

Changes made on https://github.com/WordPress/wordpress-develop/pull/5070 successfully added "Remove" via the virtual screen reader bulk edit.

Environment
WordPress: 6.4-alpha-20230824.111620
PHP: 8.1.9
Server: nginx
Database: Local WP
Browser: Chrome 115.0.5790.173
Theme: Twenty Twenty One
MU-Plugins: None activated

#12 @joedolson
6 months ago

  • Keywords changes-requested removed

Updated PR looks good!

#13 @joedolson
6 months ago

  • Keywords commit added

#14 @joedolson
6 months ago

  • Owner set to joedolson
  • Resolution set to fixed
  • Status changed from new to closed

In 56460:

Help/About: Match icon and text in Help for bulk edit button.

Change the 'x' in the Help message that instructs a user how to remove an item from a group of bulk edit items to use the dashicon and text equivalent that matches the visual and accessible control name.

Props Presskopp, costdev, sabernhardt, matthewfarlymn, bvreeman22.
Fixes #58785.

Note: See TracTickets for help on using tickets.