Make WordPress Core

Opened 9 months ago

Last modified 5 weeks ago

#58828 assigned defect (bug)

Whenever bulk updates are done in wp-admin/update-core.php, no feedback is given, until all updates are done

Reported by: bedas's profile bedas Owned by: williampatton's profile williampatton
Milestone: Future Release Priority: normal
Severity: normal Version: 6.2.2
Component: Upgrade/Install Keywords:
Focuses: accessibility, administration Cc:

Description

This bug exists since I know WP, and it still persists on the latest version.

  1. Go to wp-admin/update-core.php
  2. Check all boxes for pending updates
  3. Click update
  • The page reloads.
  • Nothing happens. The page just stays grey (admin bar etc are there, but the page itself is empty)
  • After a while, which can be a very long while if a lot of updates are pending, the screen gets populated (without page reload) with log like
    
    The update process is starting. This process may take a while on some hosts, so please be patient.
    
    Enabling Maintenance mode…
    
    Updating Plugin {Plugin name} (1/12)
    
    {Plugin name} updated successfully. Show details.
    Updating Plugin {Plugin name} 
    
    [etc]
    All updates have been completed.
    
    Go to Plugins page | Go to WordPress Updates page
    
    

This log clearly should happen _while_ it is updating, and not once it is done.
There is no spinner, no feedback, nothing that tells the user "something is working"

Change History (12)

This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.


9 months ago

#2 @NekoJonez
9 months ago

I personally agree with this.
At least, the first sentence of that log should appear to start.

Saying that... I find this also extremely silly:

{Plugin name} updated successfully. Show details.
Updating Plugin {Plugin name}

Why does it show "Updating plugin" underneath the "show details". That should be only for errors imho. But that might be a whole other ticket maybe.

I had coworkers who help me to maintain my websites say: "Are the updates actually running or not?"
So, I 100% agree.

Also, this log would a nice place for @afragen to hook the rollback into when plugin/theme updates cause errors.

#3 @afragen
9 months ago

@NekoJonez you should try the Rollback Update Failure feature plugin. It really is hooked and works for both manual and auto updates. 😉

#4 @bedas
9 months ago

@NekoJonez

Why does it show "Updating plugin" underneath the "show details". That should be only for errors imho. But that might be a whole other ticket maybe.

It maybe was not clear in my report, but there in an [etc] below this:

<?php
{Plugin name} updated successfully. Show details.
Updating Plugin {Plugin name} 

Actually what you see _after_ the updates are done is basically a list/flow of

  • updating plugin X
  • plugin X updated
  • updating plugin Y
  • updated plugin Y
  • etc

And that is good! But, it should show _while_ this happens and not once it's done.
This is bug, not an enhancement, just to clarify - because clearly the log is intended to be shown in real time and not after the facts.

Last edited 9 months ago by bedas (previous) (diff)

This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.


8 months ago

This ticket was mentioned in Slack in #core-upgrade-install by pbiron. View the logs.


8 months ago

This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.


6 months ago

This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.


6 weeks ago

#9 @joedolson
6 weeks ago

  • Milestone changed from Awaiting Review to Future Release
  • Owner set to williampatton
  • Status changed from new to assigned

Given how long this has been sitting, and knowing that it's going to be quite complicated, I'm shifting this to future release. Per request, I'm assigning to @williampatton for continuing investigation, however.

#10 @costdev
6 weeks ago

  • Keywords reporter-feedback added

This issue isn't reproducible in all environments. I'm on Chrome, and the site is running in Ubuntu, and each update appears as it happens.

Some environment information to try to narrow this down would be great! Also check the console for potential errors.

#11 @bedas
5 weeks ago

This issue has been 100% replicable for since I know WP (more than 12 years meanwhile), not only for me but many other users.

I do not know about @NekoJonez who seems to experience the same issue, however me and my clients usually are on Macs, making this the only "common" thing - since it happens on Firefox, Chrome, Safari... no matter.

The <iframe src="update.php?action=update-selected&amp;plugins={plugin-files-here}&amp;_wpnonce={nonce-here}" style="width: 100%; height: 100%; min-height: 750px;" frameborder="0" title="Update progress"></iframe> body is simply empty, until the updates are done. It does actually use the space in the HTML but its contents are not shown (body is empty). Only once the process is done, the contents are shown.

There are no errors in the console at all.

Last edited 5 weeks ago by bedas (previous) (diff)

#12 @bedas
5 weeks ago

  • Keywords reporter-feedback removed
Note: See TracTickets for help on using tickets.