Opened 2 months ago
Last modified 34 hours ago
#58831 new task (blessed)
Coding Standards fixes for WP 6.4
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | 6.4 | Priority: | normal |
Severity: | normal | Version: | |
Component: | General | Keywords: | has-patch has-unit-tests |
Focuses: | coding-standards | Cc: |
Attachments (18)
Change History (72)
#2
@
2 months ago
Thanks! These patches all look good to me.
Do you plan to commit them? If so, I think they're all good to ship, now that 6.3 has been branched.
#3
@
2 months ago
Do you plan to commit them?
I'm neck-deep in WPCS at the moment. I've asked @SergeyBiryukov if he'd be so kind as to commit these.
#4
in reply to:
↑ 1
;
follow-up:
↓ 5
@
2 months ago
Replying to jrf:
I've just uploaded 8 pretty small patches.
Thank you!
As previously noted in comment:1:ticket:50085, the change to __DIR__
in wp-tests-config-sample.php
was previously reverted in [47201] to avoid breaking unit tests created with the wp scaffold plugin
WP-CLI command, see comment:15:ticket:48082 and #49377 for details. It might be worth checking if that concern is still relevant.
Other patches look good to me at a glance :)
#5
in reply to:
↑ 4
@
2 months ago
Replying to SergeyBiryukov:
As previously noted in comment:1:ticket:50085, the change to
__DIR__
inwp-tests-config-sample.php
was previously reverted in [47201] to avoid breaking unit tests created with thewp scaffold plugin
WP-CLI command, see comment:15:ticket:48082 and #49377 for details. It might be worth checking if that concern is still relevant.
Ah, that's good to know. We may need to put an exception in place for that file once WPCS 3.0.0 comes out (which will flag this).
Having read up on the discussion, I don't think this concern will ever really go away completely, as, even though the WP-CLI scaffold plugin script has been updated, the problem is not the script itself, but the fact that there are countless plugins using a copy of that script and getting all those copies updated to the latest version is a manual process (and in the mean time CI workflows would break).
#12
follow-up:
↓ 13
@
2 months ago
@SergeyBiryukov thanks for the update - do you plan on creating the required backport to Gutenberg for your change to the Tag Processor?
This ticket was mentioned in PR #3873 on WordPress/wordpress-develop by @SergeyBiryukov.
8 weeks ago
#14
- Keywords has-patch has-unit-tests added
This ticket was mentioned in PR #4922 on WordPress/wordpress-develop by @SergeyBiryukov.
8 weeks ago
#15
Trac ticket: https://core.trac.wordpress.org/ticket/58831
This ticket was mentioned in PR #5042 on WordPress/wordpress-develop by @jrf.
5 weeks ago
#33
### PHPCS: improve organisation of the PHPCompatibility ruleset
No functional changes.
This commit:
- Adds section headers to the ruleset file.
- Organizes all directives in their respective sections.
### PHPCS: remove unnecessary directives in PHPCompatibility ruleset
This commit:
- Removes the unnecessary exclusion patterns for the
node_modules
and thevendor
directory.
As this ruleset only scans the
src
directory, those directories would never be scanned anyway.
- Removes the selective excludes related to the Random Compat package.
This package was removed in WP 6.3, so these excludes are no longer necessary.
---
Trac ticket: https://core.trac.wordpress.org/ticket/58831
@
2 weeks ago
I have checked above mentioned issue and founds another file. Here, I have added its patch.
#49
in reply to:
↑ 48
;
follow-up:
↓ 50
@
7 days ago
Replying to jrf:
Re commit [56586] - FYI: the proposed change in ticket #59232 should also help in making it clearer for the future that the signatures of those methods need to stay in sync with the signature of the parent method.
Thanks! I have a draft PR there as well as part of coding sessions with @poena, @andrea, and @aristath :)
#50
in reply to:
↑ 49
@
7 days ago
Replying to SergeyBiryukov:
Thanks! I have a draft PR there as well as part of coding sessions with @poena, @andrea, and @aristath :)
Awesome!
I've just uploaded 8 pretty small patches.
About half are for things which are checked by WPCS, but flagged as a
warning
(which doesn't fail the build) and which have slipped into the codebase unnoticed.The other half are things which are not (yet) checked by WPCS, but are rules/best practices which have been fixed up before, for which new issues have slipped into the codebase.