#58833 closed task (blessed) (fixed)
Docblock improvements for 6.4
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | 6.4 | Priority: | normal |
Severity: | normal | Version: | |
Component: | General | Keywords: | has-patch has-unit-tests |
Focuses: | docs, coding-standards | Cc: |
Change History (39)
This ticket was mentioned in PR #5009 on WordPress/wordpress-develop by @NekoJonez.
18 months ago
#1
- Keywords has-patch has-unit-tests added
#2
@
18 months ago
Found ten cases in the WP code where, for PHPCS comments, a space was forgotten. In the above PR I change those.
This ticket was mentioned in PR #5010 on WordPress/wordpress-develop by @NekoJonez.
18 months ago
#3
I found that the sentence in this doc flows weird... It's as if there is a verb missing.
Trac ticket: https://core.trac.wordpress.org/ticket/58833
This ticket was mentioned in Slack in #core by nekojonez. View the logs.
18 months ago
@audrasjb commented on PR #5010:
18 months ago
#11
It looks understandable on my side so I'd say it's ok to keep it as it is, but I'm not a native English speaker.
By the way there is another occurrence just above this hook.
@audrasjb commented on PR #5009:
18 months ago
#18
Committed in https://core.trac.wordpress.org/changeset/56472
#22
@
17 months ago
block_core_navigation_add_directives_to_submenu
in /wp-includes/blocks/navigation.php
says the parameter $w
is a string, but the function treats it as an object. Should the docblock be updated in core or in the Gutenberg repo? Or is this correct?
This ticket was mentioned in PR #5304 on WordPress/wordpress-develop by @kebbet.
17 months ago
#23
16 months ago
#29
Commited in https://core.trac.wordpress.org/ticket/58833
This ticket was mentioned in PR #5507 on WordPress/wordpress-develop by @kebbet.
16 months ago
#31
Fixing minor style issues in the comments, after 6.3.2
.
#35
@
16 months ago
- Resolution set to fixed
- Status changed from new to closed
The RC1 release party is about to start. Closing this as fixed. Thank you everyone for your contributions :)
16 months ago
#36
Please review and feel free to approve (and commit) if you have the time to do it @costdev !
16 months ago
#37
Please review and feel free to approve (and commit) if you have the time to do it @costdev !
@SergeyBiryukov commented on PR #5507:
15 months ago
#38
Thanks for the PR! Merged in r57120.
@SergeyBiryukov commented on PR #5010:
6 months ago
#39
Thanks for the PR! Merged in r58842.
In 434 cases, in the WP code a comment about PHPCS is used. In 424 cases, this is written like
phpcs:*
Yet, in ten cases... the first space is forgotten. In this PR, I want to improve that. Since this is imo a doc block improvement, I'm going to attach the Trac ticket for doc block improvements for 6.4