Opened 2 months ago
Last modified 5 days ago
#58833 new task (blessed)
Docblock improvements for 6.4
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | 6.4 | Priority: | normal |
Severity: | normal | Version: | |
Component: | General | Keywords: | has-patch has-unit-tests |
Focuses: | docs, coding-standards | Cc: |
Change History (24)
This ticket was mentioned in PR #5009 on WordPress/wordpress-develop by @NekoJonez.
7 weeks ago
#1
- Keywords has-patch has-unit-tests added
#2
@
7 weeks ago
Found ten cases in the WP code where, for PHPCS comments, a space was forgotten. In the above PR I change those.
This ticket was mentioned in PR #5010 on WordPress/wordpress-develop by @NekoJonez.
7 weeks ago
#3
I found that the sentence in this doc flows weird... It's as if there is a verb missing.
Trac ticket: https://core.trac.wordpress.org/ticket/58833
This ticket was mentioned in Slack in #core by nekojonez. View the logs.
7 weeks ago
@audrasjb commented on PR #5010:
5 weeks ago
#11
It looks understandable on my side so I'd say it's ok to keep it as it is, but I'm not a native English speaker.
By the way there is another occurrence just above this hook.
@audrasjb commented on PR #5009:
5 weeks ago
#18
Committed in https://core.trac.wordpress.org/changeset/56472
#22
@
9 days ago
block_core_navigation_add_directives_to_submenu
in /wp-includes/blocks/navigation.php
says the parameter $w
is a string, but the function treats it as an object. Should the docblock be updated in core or in the Gutenberg repo? Or is this correct?
In 434 cases, in the WP code a comment about PHPCS is used. In 424 cases, this is written like
phpcs:*
Yet, in ten cases... the first space is forgotten. In this PR, I want to improve that. Since this is imo a doc block improvement, I'm going to attach the Trac ticket for doc block improvements for 6.4