Opened 19 months ago
Last modified 3 months ago
#58836 accepted enhancement
Remove IE specific checks from more default themes
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 6.8 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch needs-testing |
Focuses: | Cc: |
Description
Follow-up to #56699
Remove IE conditional statements and register external resources without enqueuing them for four more themes:
- Twenty Eleven
- Twenty Twelve
- Twenty Fourteen
- Twenty Sixteen
Attachments (1)
Change History (19)
This ticket was mentioned in Slack in #core by oglekler. View the logs.
18 months ago
#4
@
11 months ago
- Keywords reporter-feedback removed
- Summary changed from Remove IE specific checks from more default themes (6.4) to Remove IE specific checks from more default themes
#56699 only committed changes to Twenty Thirteen, Twenty Fifteen and Twenty Seventeen.
The remaining pull requests on that ticket seem close to ready, but I still have not created child themes to test them.
- PR 3474 is probably closer to how Twenty Eleven should be changed than the other PR, though I would prefer to leave the
readme.txt
andhtml5.js
intact. That can be refreshed now that [57886] is committed. Removing the IE7 styles would also fix #46771. - PR 4642 edits Twenty Twelve.
- PR 4644 edits Twenty Fourteen.
- PR 4658 edits Twenty Sixteen.
#6
@
7 months ago
@sabernhardt I am coming to this a little colder so wanted to get an update and see how we can progress. It seems we have 3 outstanding PRS that could relate to this - is that correct?
#7
@
7 months ago
- Keywords needs-testing-info added
- Owner set to sabernhardt
- Status changed from new to accepted
I need to create some child themes to test the patches, though I would like to add more changes. Genericons can be updated for Twenty Thirteen through Twenty Sixteen so the EOT file reference does not show console messages in Firefox (and at least the Instagram icon is newer). Plus, I remember planning to request a change to one of the PRs (I found my note later, and it involved Genericons).
Refreshing Twenty Eleven's patch needs to wait until after Tuesday due to version bumps, but the child themes should take longer than that anyway.
#8
@
7 months ago
Ok that sounds like a solid plan @sabernhardt and I am going to leave this with you for now then.
This ticket was mentioned in PR #7411 on WordPress/wordpress-develop by @sabernhardt.
5 months ago
#10
- Keywords has-patch added; needs-patch removed
Twenty Eleven changes:
- Removes IE conditional code and HTML5 Shiv from
header.php
- Removes IE7 and IE8 sections from
style.css
andrtl.css
- Removes
width
fromeditor-style.css
- Removes extra
clip
syntax fromfunctions.php
andstyle.css
- Removes
filter
fromstyle.css
anddark.css
- Removes IE8
width: auto
rule for full-size and large-size images instyle.css
Props: neychok
This ticket was mentioned in PR #7412 on WordPress/wordpress-develop by @sabernhardt.
5 months ago
#11
Twenty Twelve changes:
- Registers
ie.css
without enqueuing it - Removes IE conditional code and HTML5 Shiv from
header.php
- Removes
width
hack fromeditor-style.css
- Removes extra
clip
syntax fromcustom-header.php
Props: metodiew
This ticket was mentioned in PR #7414 on WordPress/wordpress-develop by @sabernhardt.
5 months ago
#12
Twenty Fourteen changes:
- Registers
ie.css
without enqueuing it - Removes IE conditional code and HTML5 Shiv from
header.php
- Removes extra
clip
syntax fromcustom-header.php
Props: metodiew
This ticket was mentioned in PR #7416 on WordPress/wordpress-develop by @sabernhardt.
5 months ago
#13
Twenty Sixteen changes:
- Registers IE styles and HTML5 script without enqueuing them
- Removes IE fallback for RGBA colors in
customizer.php
and adds a semicolon
Props: metodiew
#14
@
5 months ago
The remaining pull requests from #56699 (that neychok and metodiew made) were mostly ready, but I wanted to connect all of them to this ticket in sequence.
I still should test a bit more before taking them out of draft status and uploading the child themes collection.
I think updating Genericons belongs on a separate ticket because that should involve more than IE-related changes.
@
5 months ago
Child themes for testing Twenty Eleven, Twenty Twelve, Twenty Fourteen and Twenty Sixteen
This ticket was discussed during a bug scrub.
@sabernhardt does there is still work to be done? If so, please clarify the scope, because #56699 is closed and had the same themes mentioned.
Add props to @mukesh27