Make WordPress Core

Opened 12 months ago

Last modified 15 hours ago

#58836 accepted enhancement

Remove IE specific checks from more default themes

Reported by: sabernhardt's profile sabernhardt Owned by: sabernhardt's profile sabernhardt
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: needs-patch
Focuses: Cc:


Follow-up to #56699

Remove IE conditional statements and register external resources without enqueuing them for four more themes:

  • Twenty Eleven
  • Twenty Twelve
  • Twenty Fourteen
  • Twenty Sixteen

Change History (9)

This ticket was mentioned in Slack in #core by oglekler. View the logs.

11 months ago

#2 @oglekler
11 months ago

  • Keywords reporter-feedback added; has-patch removed

This ticket was discussed during a bug scrub.

@sabernhardt does there is still work to be done? If so, please clarify the scope, because #56699 is closed and had the same themes mentioned.

Add props to @mukesh27

#3 @sabernhardt
10 months ago

  • Milestone changed from 6.4 to Future Release

#4 @sabernhardt
4 months ago

  • Keywords reporter-feedback removed
  • Summary changed from Remove IE specific checks from more default themes (6.4) to Remove IE specific checks from more default themes

#56699 only committed changes to Twenty Thirteen, Twenty Fifteen and Twenty Seventeen.

The remaining pull requests on that ticket seem close to ready, but I still have not created child themes to test them.

  • PR 3474 is probably closer to how Twenty Eleven should be changed than the other PR, though I would prefer to leave the readme.txt and html5.js intact. That can be refreshed now that [57886] is committed. Removing the IE7 styles would also fix #46771.
  • PR 4642 edits Twenty Twelve.
  • PR 4644 edits Twenty Fourteen.
  • PR 4658 edits Twenty Sixteen.

#5 @karmatosed
4 weeks ago

  • Keywords dev-feedback added

#6 @karmatosed
7 days ago

@sabernhardt I am coming to this a little colder so wanted to get an update and see how we can progress. It seems we have 3 outstanding PRS that could relate to this - is that correct?

#7 @sabernhardt
6 days ago

  • Keywords needs-testing-info added
  • Owner set to sabernhardt
  • Status changed from new to accepted

I need to create some child themes to test the patches, though I would like to add more changes. Genericons can be updated for Twenty Thirteen through Twenty Sixteen so the EOT file reference does not show console messages in Firefox (and at least the Instagram icon is newer). Plus, I remember planning to request a change to one of the PRs (but I couldn't find my note the last time I revisited this).

Refreshing Twenty Eleven's patch needs to wait until after Tuesday due to version bumps, but the child themes should take longer than that anyway.

#8 @karmatosed
15 hours ago

Ok that sounds like a solid plan @sabernhardt and I am going to leave this with you for now then.

#9 @karmatosed
15 hours ago

  • Keywords needs-patch added; dev-feedback needs-testing-info removed
Note: See TracTickets for help on using tickets.