Remove IE specific checks from more default themes

[sabernhardt]

Follow-up to #56699

Remove IE conditional statements and register external resources without enqueuing them for four more themes:

• Twenty Eleven
• Twenty Twelve
• Twenty Fourteen
• Twenty Sixteen

[oglekler]

This ticket was discussed during a bug scrub.

@sabernhardt does there is still work to be done? If so, please clarify the scope, because #56699 is closed and had the same themes mentioned.

Add props to @mukesh27

[sabernhardt]

#56699 only committed changes to Twenty Thirteen, Twenty Fifteen and Twenty Seventeen.

The remaining pull requests on that ticket seem close to ready, but I still have not created child themes to test them.

• ​PR 3474 is probably closer to how Twenty Eleven should be changed than the other PR, though I would prefer to leave the readme.txt and html5.js intact. That can be refreshed now that [57886] is committed. Removing the IE7 styles would also fix #46771.
• ​PR 4642 edits Twenty Twelve.
• ​PR 4644 edits Twenty Fourteen.
• ​PR 4658 edits Twenty Sixteen.

[karmatosed]

@sabernhardt I am coming to this a little colder so wanted to get an update and see how we can progress. It seems we have 3 outstanding PRS that could relate to this - is that correct?

[sabernhardt]

I need to create some child themes to test the patches, though I would like to add more changes. Genericons can be updated for Twenty Thirteen through Twenty Sixteen so the EOT file reference does not show console messages in Firefox (and at least the Instagram icon is newer). Plus, I remember planning to request a change to one of the PRs (I found my note later, and it involved Genericons).

Refreshing Twenty Eleven's patch needs to wait until after Tuesday due to version bumps, but the child themes should take longer than that anyway.

[karmatosed]

Ok that sounds like a solid plan @sabernhardt and I am going to leave this with you for now then.

Twenty Eleven changes:

• Removes IE conditional code and HTML5 Shiv from header.php
• Removes IE7 and IE8 sections from style.css and rtl.css
• Removes width from editor-style.css
• Removes extra clip syntax from functions.php and style.css
• Removes filter from style.css and dark.css
• Removes IE8 width: auto rule for full-size and large-size images in style.css

Trac 58836

Props: neychok

Twenty Twelve changes:

• Registers ie.css without enqueuing it
• Removes IE conditional code and HTML5 Shiv from header.php
• Removes width hack from editor-style.css
• Removes extra clip syntax from custom-header.php

Trac 58836

Props: metodiew

Twenty Fourteen changes:

• Registers ie.css without enqueuing it
• Removes IE conditional code and HTML5 Shiv from header.php
• Removes extra clip syntax from custom-header.php

Trac 58836

Props: metodiew

Twenty Sixteen changes:

• Registers IE styles and HTML5 script without enqueuing them
• Removes IE fallback for RGBA colors in customizer.php and adds a semicolon

Trac 58836

Props: metodiew

[sabernhardt]

The remaining pull requests from #56699 (that neychok and metodiew made) were mostly ready, but I wanted to connect all of them to this ticket in sequence.

I still should test a bit more before taking them out of draft status and uploading the child themes collection.

I think updating Genericons belongs on a separate ticket (#62128) because that should involve more than IE-related changes.

[sabernhardt]

Child themes for testing Twenty Eleven, Twenty Twelve, Twenty Fourteen and Twenty Sixteen

[sabernhardt]

Moving to 6.8 for more testing

[neychok]

Hi there! @metodiew and I are currently attending a contributor day in WordCamp Sofia 2024, and we're eager to help move this ticket forward. Would you be open to our assistance? We'd love to contribute and help make progress on this.

[sabernhardt]

#62937 was marked as a duplicate.

[audrasjb]

As per today's bug scrub: It appears this ticket is still under review and needs testing. As 6.8 beta 1 is very close, I'm moving it to 6.9. Feel free to move it back to 6.8 if it can be committed by Monday.

[SirLouen]

@sabernhardt could you provide clear reproduction steps to understand what to expect before and after this patch?