WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #58856


Ignore:
Timestamp:
07/20/2023 04:52:20 AM (15 months ago)
Author:
costdev
Comment:

Hi @nendeb55, thanks for opening this ticket.

str_contains() was polyfilled in WordPress 5.9 (changeset [52039]) along with several others such as str_starts_with(), str_ends_with(), array_key_first() and array_key_last().

These can all be used safely as long as /wp-includes/compat.php has been included somewhere in the callstack, which is the case with wp-login.php.

As this is used safely in the mentioned file, I'll close this ticket as invalid.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #58856

    • Property Status changed from new to closed
    • Property Component changed from General to Login and Registration
    • Property Version changed from trunk to
    • Property Milestone changed from Awaiting Review to
    • Property Keywords needs-patch removed
    • Property Resolution changed from to invalid
    • Property Severity changed from critical to normal

  • Ticket #58856 – Description

    initial v1  
    1 You should revert to strpos() since str_contains() is from php8.0.
     1You should revert to `strpos()` since `str_contains()` is from php8.0.
    22
    33WordPress6.3 RC1