WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 6 years ago

#5886 closed defect (bug) (fixed)

Widgets' Cancel links don't really work

Reported by: Otto42 Owned by: mdawaffe
Milestone: 2.8 Priority: normal
Severity: normal Version: 2.5
Component: Widgets Keywords:
Focuses: Cc:

Description

Current trunk.

When editing a text widget, there's a link on the bottom left named "Change" and a link in the upper right named "Cancel". These links do basically the same thing as far as I can tell. Either way, changes you've made to the content of the widget is altered. When you "Save Changes", your widget will be altered.

Seems like a usability issue to me.

Attachments (1)

5886.diff (5.6 KB) - added by mdawaffe 7 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 @ryan7 years ago

  • Owner changed from anonymous to mdawaffe

comment:2 @mdawaffe7 years ago

  • Status changed from new to assigned

I'll work on this soon.

I think this is a release blocker, but not a beta blocker.

comment:3 @bryan8687 years ago

I'd like to recommend doing away with the overall "Save Changes" button and give the individual widget buttons 'global control.' So when you remove a widget, it's really gone; or when you make changes to a widget, they automatically stick.

This will allow us to navigate multiple sidebars more quickly, without having to hit the "Save Changes" button every single time.

comment:4 @mdawaffe7 years ago

  • Keywords has-patch 2nd-opinion added

5886.diff disables widget form elements on cancel so that the canceled changes are not saved.

What it does.

  1. Load the widget page.
  2. Click "Edit" on a widget. Make some change. Click "Cancel".
  3. Click "Save Changes" on the bottom.
  4. Notice that the changes you canceled were not saved. The content is the same as when you first loaded the page.

It's not perfect.

  1. Load the widget page.
  2. Click "Edit" on a widget. Make some change. Click "Change".
  3. Re-edit that widget by again clicking "Edit" on that widget. Make some more changes. Click "Cancel"
  4. Click "Save Changes" on the bottom.
  5. Notice that no changes were saved. The content is the same as when you first loaded the page. One might have expected the first change you made to be saved (you didn't cancel that change), but the second to be discarded.

To fix that bug, we'd either have to store old states of widgets in JS, or have the "Change" and "Cancel" buttons do ajax requests (which would implement bryan868`s recommendation). Unless this is marked as a high priority, neither of those things is going to happen this late in the game.

@mdawaffe7 years ago

comment:5 @bryan8687 years ago

Why shouldn't this be a high priority is the question. Who can deem it a high priority?

comment:6 @ryan7 years ago

(In [7176]) Make cancel mean cancel. Props mdawaffe. see #5886

comment:7 @mdawaffe7 years ago

  • Keywords has-patch 2nd-opinion removed
  • Milestone changed from 2.5 to 2.6
  • Summary changed from Text Widget - Cancel link doesn't work to Widgets' Cancel links don't really work

AJAX fanciness isn't going to happen in 2.5.

comment:8 @bryan8687 years ago

When will the AJAX fanciness occur?

comment:9 @ryan6 years ago

  • Component changed from General to Widgets

comment:10 @Denis-de-Bernardy6 years ago

possibly fixed. see #9511

comment:11 @azaozz6 years ago

  • Milestone changed from 2.9 to 2.8
  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed with the widgets UI redesign. On the new widgets page saving is done with ajax for each widget separately. Canceling is no longer an issue.

Note: See TracTickets for help on using tickets.