#58863 closed task (blessed) (fixed)
Update/Audit NPM Dependencies for 6.4
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 6.4 | Priority: | normal |
| Severity: | normal | Version: | |
| Component: | Build/Test Tools | Keywords: | has-patch |
| Focuses: | Cc: |
Description
Attachments (2)
Change History (17)
This ticket was mentioned in PR #5264 on WordPress/wordpress-develop by @desrosj.
2 years ago
#5
- Keywords has-patch added
This includes Webpack and React related updates to accompany WordPress/Gutenberg#54657.
Trac ticket: https://core.trac.wordpress.org/ticket/58863
#6
@
2 years ago
- Owner set to desrosj
- Resolution set to fixed
- Status changed from new to closed
In 56647:
#7
@
2 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
@rajinsharwar Sorry, I missed your patch above for framer-motion and @emotion/is-prop-valid.
I just opened an upstream issue on GitHub to update framer-motion in Gutenberg first to ensure there are no issues. @emotion/is-prop-valid also should be investigated there first.
Running npm list @emotion/is-prop-valid results in this:
├── @emotion/is-prop-valid@0.8.8 ├─┬ @wordpress/block-editor@12.3.14 │ └─┬ @emotion/styled@11.10.6 │ └── @emotion/is-prop-valid@1.2.1 └─┬ framer-motion@10.11.6 └── @emotion/is-prop-valid@0.8.8 d
I'm not that it's necessary to include this as a direct dependency.
This ticket was mentioned in PR #5273 on WordPress/wordpress-develop by @desrosj.
2 years ago
#9
Since version 20.0.0, puppeteer uses Chrome instead of Chromium for testing. The PUPPETEER_SKIP_CHROMIUM_DOWNLOAD environment variable was removed in favor of PUPPETEER_SKIP_DOWNLOAD.
puppeteer is a peer dependency of grunt-contrib-qunit, which was updated in [56647].
This changes PUPPETEER_SKIP_CHROMIUM_DOWNLOAD to PUPPETEER_SKIP_DOWNLOAD in order to restore the previous behavior of not downloading the desired binary in workflows where it's not required.
Trac ticket: https://core.trac.wordpress.org/ticket/58863
#12
@
2 years ago
I just wanted to note that one of the changes here (I think [56647]) in combination with gutenberg https://github.com/WordPress/gutenberg/pull/52993 suddenly made the gutenberg build fail on my local environment this morning. Very likely, I'm not the only one who faced this issue. For more details, please see this comment: https://github.com/WordPress/gutenberg/pull/52993#issuecomment-1735409085
Contributors may have very different local development environments. Cloning the gutenberg repository inside the core plugins directory is a legitimate way to set up a dev environment, in my opinion. Ideally, changes in core and gutenberg should never break the build process, whatever the development environment is. I do realize managing packages versions across two projects is complicated but I'd really like to see more coordination to avoid a frustrating development experience for many contributors.
To carry over a few unaddressed items from #57657:
This pull request updates a few dependencies, but some overlap preexisting tickets such as #56731 for
imagesloaded.cssnanois also out of date, and several updates are blocked by raising the minimum version of NodeJS to >= 16.0. This will be addressed in #56658.Props to @tanjimtc71 and @hareesh-pillai for calling these out.