WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#5890 closed defect (bug) (fixed)

Theme editor font sizing and layout errors

Reported by: ionfish Owned by:
Milestone: 2.5 Priority: normal
Severity: normal Version: 2.5
Component: Administration Keywords: theme-editor has-patch needs-testing
Focuses: Cc:

Description

This patch makes the theme editor present its fonts in a more Safari-friendly way (currently the code in the textarea is very small); I've followed the convention elsewhere to set the fonts in pixels, but I can attach an additional patch to allow resizing in IE6 if required.

Additionally, when the list of files is longer than the textarea, the "You need to make this file writable" text overflows the left column into the list of files. The attached patch restricts the text to the left column.

Attachments (3)

template_layout.patch (1.3 KB) - added by ionfish 6 years ago.
templateside_layout.patch (428 bytes) - added by ionfish 6 years ago.
remove_small.diff (971 bytes) - added by ionfish 6 years ago.

Download all attachments as: .zip

Change History (10)

ionfish6 years ago

comment:1 ryan6 years ago

(In [6890]) Theme editor font sizing and layout fixes from ionfish. see #5890

comment:2 ryan6 years ago

Also, after doing "Update File" the confirmation message at the top messes up layout.

comment:3 ionfish6 years ago

  • Keywords needs-testing added

Needs testing in Internet Explorer; works ok on Saf3/Mac and FF2/Mac.

comment:4 ryan6 years ago

(In [6908]) Theme editor layout fixes from ionfish. see #5890

comment:5 ryan6 years ago

I don't have IE, but committed to make it easier for those that do to test.

comment:6 ryan6 years ago

From the tester's list:

On the "Theme Files" list, an unneeded </small> tag is included after
the "nonessential" span.

<li><a href="theme-editor.php?file=...">404 Template <span class='nonessential'>(404.php)</span>/*</small>*/</a></li>

ionfish6 years ago

comment:7 ryan6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [6960]) Remove extraneous tag. Props ionfish. fixes #5890

Note: See TracTickets for help on using tickets.