WordPress.org
Get WordPress

Make WordPress Core

Opened 17 months ago

Closed 16 months ago

#58920 closed defect (bug) (reported-upstream)

Template Parts: Prevent PHP warning when accessing icon by area

Reported by: aaronrobertshaw's profile aaronrobertshaw Owned by: audrasjb's profile audrasjb
Milestone: Priority: normal
Severity: normal Version:
Component: Editor Keywords: gutenberg-merge
Focuses: Cc:

Description

This ticket tracks the backporting of PHP files for the following Gutenberg changes:

​https://github.com/WordPress/gutenberg/pull/52961

This minor update prevents an attempt to access an array via a key that doesn't exist.

Change History (14)

This ticket was mentioned in ​PR #4919 on ​WordPress/wordpress-develop by ​@aaronrobertshaw.
17 months ago #1

  • Keywords has-patch added

This is a backport PR for WordPress 6.3 that includes the following PHP Gutenberg changes:

​https://github.com/WordPress/gutenberg/pull/52961

Trac ticket: https://core.trac.wordpress.org/ticket/58920

#2 @audrasjb
17 months ago

  • Milestone changed from Awaiting Review to 6.3

#3 @audrasjb
17 months ago

  • Keywords commit added
  • Owner set to audrasjb
  • Status changed from new to accepted

Self assigning for trunk commit.

#4 @audrasjb
17 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 56316:

Editor: Prevent PHP warning when accessing icon by area.

This changeset prevents an attempt to access an array via a key that doesn't exist.
See ​https://github.com/WordPress/gutenberg/pull/52961.

Props aaronrobertshaw, glendaviesnz, mukesh27.
Fixes #58920.

#5 @audrasjb
17 months ago

  • Keywords dev-feedback fixed-major added; commit removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for 6.3 backport consideration, pending a second committer review.

#7 @swissspidy
17 months ago

[56316] needs to be reverted, this change needs to be made in Gutenberg. Otherwise an npm install will override the change again.

See failing tests at ​https://github.com/WordPress/wordpress-develop/actions/runs/5678772198/job/15389833498 for example.

#8 @swissspidy
17 months ago

Okay, so this was fixed in Gutenberg already, which means this will need to be fixed in core by updating npm packages. (It's not technically a backport)

#9 @audrasjb
17 months ago

  • Keywords revert added; dev-feedback fixed-major removed

You're right, this file should be updated in Gutenberg, I made a wrong assumption about this ticket since a PR was proposed against wordpress-develop and as it was also mentioned in the Gutenberg PR.

Reverting now.

#10 @audrasjb
17 months ago

In 56317:

Editor: Revert [56316].

This reverts [56316] as it needs to be fixed by updating npm packages.

Unprops audrasjb.
Props swissspidy.
See #58920.

#11 @audrasjb
17 months ago

  • Keywords has-patch revert removed

#12 @aaronrobertshaw
17 months ago

Apologies for the confusion on this. I was under the impression I needed to backport the change given the warning was still thrown in core even with the update in Gutenberg.

#13 @audrasjb
17 months ago

Yep, no worries :)
Should we close this as reported-upstream given it will be fixed with the next package update?

#14 @audrasjb
16 months ago

  • Milestone 6.3 deleted
  • Resolution set to reported-upstream
  • Status changed from reopened to closed

Closing this as reported-upstream since it was indeed fixed in [56320].

Note: See TracTickets for help on using tickets.