Changes between Initial Version and Version 1 of Ticket #58962, comment 19
- Timestamp:
- 10/19/2023 06:02:18 PM (12 months ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #58962, comment 19
initial v1 1 1 I'm onboard with the `prime_options_cache()` name (or `prime_option_caches()`), but I strongly object to prefixing the function with an underscore, which is a clear indicator of private functions, which this function is not and was never intended to be. 2 2 3 The existing functions to prime caches started as private functions, and I would argue even today they are primarily used by WordPress core. That is different with the functions here which are primarily introduced for plugins to make sure of them.3 The existing functions to prime caches started as private functions, and I would argue even today they are primarily used by WordPress core. That is different with the functions here which are primarily introduced for plugins to make use of them. 4 4 5 5 Prefixing a public function just for consistency sake with existing private functions which ''may'' now be considered public is taking the point of consistency too far IMO.