Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #58962, comment 23


Ignore:
Timestamp:
10/23/2023 02:15:09 PM (12 months ago)
Author:
flixos90
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #58962, comment 23

    v1 v2  
    77> * `wp_load_options_group()`
    88
    9 I like the idea of separating the names more obviously. Only one suggested change: The second should remain `...options_by_group()` IMO because it's loading options, not an option group. The two functions are conceptually doing the same thing, and the latter is a convenience wrapper. So IMO we shouldn't change the noun/object of ''what'' is loaded.
     9I like the idea of separating the names more obviously. Only one suggested change: The second should remain `...options_by_group()` IMO because it's loading options, not an option group. The two functions are conceptually doing the same thing, and the latter is a convenience wrapper. So IMO we shouldn't change the noun/object of ''what'' is loaded. If there is a concern about the "by", maybe we could use "for" instead?
    1010
    1111The other potential concern is that existing option functions don't use the `wp_` prefix, but I'm not opposed to introducing it here - also since the option autoload functions from #58964 already went with `wp_` anyway. Just sharing that as a further naming consideration, but I'm fine with having the `wp_` prefix on them.