Unwanted Section appears in the sidebar of Media Library after go back from Edit Image

[sruthi89]

Unwanted Section with 'Actions' and 'Select or Upload Media' texts appears in the sidebar of Media Library and nothing happens on selection or click of the texts.

To find the issue,please go through the below steps.

1.Select Media Library from the 'File' block and then select an image from the list.
2.Before click on the 'select' button , select 'Edit Image' and then go back to Media Library section such as previous section.
3.Sidebar section with the specified texts appears.

[nithi22]

I could reproduce this issue

[nithi22]

After edit image

[sruthi89]

Replying to sruthi89:

Unwanted Section with 'Actions' and 'Select or Upload Media' texts appears in the sidebar of Media Library and nothing happens on selection or click of the texts.

To find the issue,please go through the below steps.

1.Select Media Library from the 'File' block and then select an image from the list.
2.Before click on the 'select' button , select 'Edit Image' and then go back to Media Library section such as previous section.
3.Sidebar section with the specified texts appears.

Environment

WordPress: 6.3-RC3-56344
PHP: 7.4.33
Server: TasteWP-S4 Official/3.0.0
Database: mysqli (Server: 8.0.32-0ubuntu0.20.04.2 / Client: mysqlnd 7.4.33)
Browser: Firefox 116.0 (Windows 10/11)
Theme: Twenty Twenty-Three 1.2
MU-Plugins: None activated

Plugins:
WordPress Beta Tester 3.5.2

Steps to Reproduce
1.Select Media Library from the 'File' block or 'Image' block and then select an image from the list.
2.Before click on the 'select' button , select 'Edit Image' and then go back to Media Library section such as previous section.
3.Sidebar section with the specified texts appears.

Expected Results
There is no need of such sidebar section.

Actual Results
Sidebar section with just texts with no click action appears.

[joemcgill]

I can reproduce this issue also with WP 6.2.2, so this seems to be an existing bug.

Hi there!

I've added a small fix for the issue. Now, the Action menu shows only if it has more than one item, the same way like it happens here: ​wp.media.view.Menu.visibility

[joedolson]

Testing instructions

1.Select Media Library from the 'File' block or 'Image' block and then select an image from the list.
2.Before click on the 'select' button , select 'Edit Image' and then go back to Media Library section such as previous section.
3.Sidebar section with the specified texts appears.

Before patch
-Sidebar action panel with no actions.

After patch
-Sidebar action panel is not visible.

[ukdrahul]

Test Report

Environment

• WordPress: 6.5-beta1
• PHP: 8.1.23
• Server: Apache v2.4.58
• Database: MySQL 8.0.16
• Browser: Chrome v121.0.6167.160 (Official Build) (arm64)
• OS: macOS Sonoma v14.2.1 (23C71)
• Theme: Twenty Twenty-Four v1.0

Verdict

The issue reported in this ticket still persists in this tested environment.

[joedolson]

@ukdrahul The patch seems to work as expected for me; in case our testing process wasn't the same, I did update the testing instructions to be more clear, above.

I tested on Windows with Chrome & Firefox, but I don't really think it's very likely that this fix is OS dependent. Can you re-test the patch?

[shailu25]

Test Report

Tested Patch: https://core.trac.wordpress.org/attachment/ticket/58973/58973.diff

Testing Environment:

OS: Windows
Web Server: Nginx
PHP: 8.1.23
WordPress: 6.5-beta1
Browser: Chrome
Theme: Twenty Seventeen
Active Plugins: None

Actual Results:

• Sidebar action panel is not visible With Patch.✅

Screenshots:

Before Patch: ​https://prnt.sc/tz16mo2ynk61
After Patch: ​https://prnt.sc/AhFx61E53jiy

[joedolson]

In 57688:

Media: Prevent Media Library sidebar from showing with no actions.

Fix an issue where the actions sidebar in the media library could appear when there are no relevant actions available.

Props sruthi89, nithi22, ivanzhuck, dhruvishah2203, joemcgill, ukdrahul, joedolson, shailu25.
Fixes #58973.

In r57688

[joedolson]

This introduced an error in the media grid view; reopening to fix.

[joedolson]

Follow up patch

[antpb]

@joedolson fix looks good in my testing! thank you!

[joedolson]

In 57691:

Media: Fix broken media modal following [57688]

Fix undefined TypeError overlooked in [57688].

Props antpb, swissspidy, joedolson.
Fixes #58973.