Remove individual files from `$_old_files` array when its parent directory is already included

[davidbaumwald]

Chatting with @SergeyBiryukov, it seems that $wp_filesystem->delete( $old_file, true ) is called on entries in the array and the second parameter, $recursive, is set to true. So, individual files aren't necessary when the parent directory is included.

Some precedent exists higher up for older version where individual files were excluded, such as wp-includes/js/tinymce/plugins/wpembed.

Props to @SergeyBiryukov for the discussion.

[abhi3315]

I am taking up this issue.

The implemented update ensures that when processing the $_old_files array, any individual files referenced within the array are excluded from deletion if their corresponding parent directories are already included.

Trac ticket: https://core.trac.wordpress.org/ticket/58995

[mhshohel]

@davidbaumwald @abhi3315

I've eliminated all the individual files that are already encompassed by their parent directory within the $_old_files array.

@abhi3315, my apologies for addressing this matter, as it appears to be consuming more time than anticipated.

[mhshohel]

Attaching the differential file separately for visual reference, allowing anyone to easily observe the highlighted differences.

[pbiron]

@davidbaumwald isn't the $_old_files array generated by tooling as part of the release process? If that's true, shouldn't that tooling simply be updated to not include a file in the array if a dir in it's path has already been included in the array?

@pbiron

Hey Paul, thank you for noticing it, I've removed these two files as their parent wp-includes/js/codepress directory already exists

[pbiron]

@davidbaumwald the PR LGTM, but it wouldn't hurt to have another set of eyes on it.