#59006 closed enhancement (fixed)
No title attribute on oEmbed and REST API <link>s
| Reported by: | edent | Owned by: | audrasjb |
|---|---|---|---|
| Priority: | normal | Milestone: | 6.6 |
| Component: | Embeds | Version: | 6.2.2 |
| Severity: | normal | Keywords: | has-screenshots has-patch has-unit-tests needs-testing |
| Cc: | Focuses: | accessibility, rest-api |
Description
By default, WordPress adds three <link rel="alternate" ... to the <head> of every post.
These are missing the title="..." attribute. This means that some browsers will announce the links as "alternate" with no explanation of their destination - see screenshot attached.
The three links are:
<link rel="alternate" type="application/json" href="https://example.com/wp-json/wp/v2/posts/123" /> <link rel="alternate" type="application/json+oembed" href="https://sexample.com/wp-json/oembed/1.0/embed?url=https%3A%2F%2Fexample.com%2Fpost%2F" /> <link rel="alternate" type="text/xml+oembed" href="https://example.com/wp-json/oembed/1.0/embed?url=https%3A%2F%2Fexample.com%2Fpost%2F&format=xml" />
Ideally, these would have title="JSON", title="oEmbed (JSON)", title="oEmbed (XML)" or similar.
Attachments (1)
Change History (22)
This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.
3 years ago
#2
@
3 years ago
@TimothyBlynJacobs @rmccue Do you see any reason not to do this? I assume we'd want to translate the title strings
This ticket was mentioned in PR #5080 on WordPress/wordpress-develop by addisonhardy.
3 years ago
#4
- Keywords has-patch has-unit-tests added
This PR makes three changes:
- Adds the
titleattribute to<link rel="alternate">tags for oEmbed and REST API endpoints - Updates the oEmbed phpunit tests to reflect the above change
- Adds the
titlelink-param to REST APILink:headers (verified as supported in RFC 8288 here: https://httpwg.org/specs/rfc8288.html#serialisation-defined-attributes)
Note: The Trac ticket referenced below does not include a consensus discussion around this change. Opening the PR as a proof of concept as part of familiarizing w/ the WP development process as a new contributor at WordCamp US 2023.
Trac ticket: https://core.trac.wordpress.org/ticket/59006
@TimothyBlynJacobs commented on PR #5080:
3 years ago
#6
Maybe @SergeyBiryukov has some thoughts on localization. My inclination would be that we should still translate it.
This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.
3 years ago
@joedolson commented on PR #5080:
3 years ago
#8
I'm inclined to think these should be translated, although it does feel a little strange. At least in the case of oEmbed (XML), I think that the structure and order of the text could be variable by language, which is enough to justify it, to me.
#9
@
3 years ago
- Milestone Awaiting Review → 6.5
I think this is worth doing, even though it probably only applies in a very small number of cases. A little clarity doesn't hurt!
#10
@
3 years ago
- Keywords changes-requested added
- Owner set to
- Status new → reviewing
Yes these strings should be translatable: even if it's a edge case, as soon as the title is rendered in the user agent, any language change without information about the language of the string would be a compliance issue.
This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.
3 years ago
#12
@
3 years ago
- Milestone 6.5 → 6.6
- Type defect (bug) → enhancement
This is really more of an enhancement, so moving out of 6.5.
Not sure about the localization, but if we add it, it should use _x() with proper context.
This ticket was mentioned in Slack in #core by nhrrob. View the logs.
2 years ago
#14
@
2 years ago
We have reviewed this ticket in today's bug scrub. It still requires some changes on the PR.
This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.
2 years ago
This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.
2 years ago
This ticket was mentioned in PR #6703 on WordPress/wordpress-develop by @sabernhardt.
2 years ago
#17
Like #5080, this PR makes three changes:
- Adds the
titleattribute to<link rel="alternate">tags for oEmbed and REST API endpoints - Updates the oEmbed PHPUnit tests to reflect the above change
- Adds the
titlelink-param to REST APILink:headers (verified as supported in RFC 8288)
In addition:
- The
linknames are translatable, with context. - The
printfandsprintffunctions are on multiple lines for better readability with two placeholders.
#18
@
2 years ago
- Keywords needs-testing added; changes-requested removed
@audrasjb can you take a look, please? It is simple enough to be able to get into 6.6.
@audrasjb commented on PR #6703:
2 years ago
#20
Committed in https://core.trac.wordpress.org/changeset/58286
addisonhardy commented on PR #5080:
2 years ago
#21
Closing as no longer needed due to #6703
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Lynx browser showing the "alternate" link.