Opened 4 months ago
Last modified 2 months ago
#59006 new defect (bug)
No title attribute on oEmbed and REST API <link>s
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | 6.5 | Priority: | normal |
Severity: | normal | Version: | 6.2.2 |
Component: | Embeds | Keywords: | has-screenshots has-patch has-unit-tests |
Focuses: | accessibility, rest-api | Cc: |
Description
By default, WordPress adds three <link rel="alternate" ...
to the <head>
of every post.
These are missing the title="..."
attribute. This means that some browsers will announce the links as "alternate" with no explanation of their destination - see screenshot attached.
The three links are:
<link rel="alternate" type="application/json" href="https://example.com/wp-json/wp/v2/posts/123" /> <link rel="alternate" type="application/json+oembed" href="https://sexample.com/wp-json/oembed/1.0/embed?url=https%3A%2F%2Fexample.com%2Fpost%2F" /> <link rel="alternate" type="text/xml+oembed" href="https://example.com/wp-json/oembed/1.0/embed?url=https%3A%2F%2Fexample.com%2Fpost%2F&format=xml" />
Ideally, these would have title="JSON"
, title="oEmbed (JSON)"
, title="oEmbed (XML)"
or similar.
Attachments (1)
Change History (10)
This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.
4 months ago
#2
@
3 months ago
@TimothyBlynJacobs @rmccue Do you see any reason not to do this? I assume we'd want to translate the title strings
This ticket was mentioned in PR #5080 on WordPress/wordpress-develop by addisonhardy.
3 months ago
#4
- Keywords has-patch has-unit-tests added
This PR makes three changes:
- Adds the
title
attribute to<link rel="alternate">
tags for oEmbed and REST API endpoints - Updates the oEmbed phpunit tests to reflect the above change
- Adds the
title
link-param to REST APILink:
headers (verified as supported in RFC 8288 here: https://httpwg.org/specs/rfc8288.html#serialisation-defined-attributes)
Note: The Trac ticket referenced below does not include a consensus discussion around this change. Opening the PR as a proof of concept as part of familiarizing w/ the WP development process as a new contributor at WordCamp US 2023.
Trac ticket: https://core.trac.wordpress.org/ticket/59006
@TimothyBlynJacobs commented on PR #5080:
3 months ago
#6
Maybe @SergeyBiryukov has some thoughts on localization. My inclination would be that we should still translate it.
This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.
2 months ago
@joedolson commented on PR #5080:
2 months ago
#8
I'm inclined to think these should be translated, although it does feel a little strange. At least in the case of oEmbed (XML), I think that the structure and order of the text could be variable by language, which is enough to justify it, to me.
Lynx browser showing the "alternate" link.