Make WordPress Core

Opened 18 years ago

Closed 18 years ago

#5906 closed defect (bug) (fixed)

Border radius not specified for all browsers

Reported by: iammattthomas's profile iammattthomas Owned by:
Milestone: 2.5 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch
Focuses: Cc:

Description

Where -moz-border-radius is specified, -khtml-border-radius should be specified as well.

Attachments (5)

wp-admin.css.diff (1.9 KB) - added by iammattthomas 18 years ago.
Patch adds border radiuses for KHTML
dashboard.css.diff (362 bytes) - added by iammattthomas 18 years ago.
Patch border radius for webkit
wp-admin-css.diff (2.3 KB) - added by iammattthomas 18 years ago.
Patch border radius for webkit
dashboard.css.2.diff (502 bytes) - added by iammattthomas 18 years ago.
Patch reflects sambauers suggestion for specifying radiuses
wp-admin.css.2.diff (3.8 KB) - added by iammattthomas 18 years ago.
Patch reflects sambauers suggestion for specifying radiuses

Download all attachments as: .zip

Change History (15)

@iammattthomas
18 years ago

Patch adds border radiuses for KHTML

#1 @technosailor
18 years ago

I think you mean -webkit-border-radius which is Safari 3 implementation. Konqueror uses the former, as did <Safari 2. But come on, who uses Konqueror?

I'm of the mind that no broswer-specific CSS3 declarations should be used so I'm -1 all the way around, but if we're going to do it, we might as well use the more common CSS3 declaration used by more people and that's the webkit variant.

#2 @iammattthomas
18 years ago

I'm fine with -webkit, just chose -khtml as it was already in use elsewhere. I'll change. As to including it altogether, I think it makes sense to use it where we can for the browsers that support it.

@iammattthomas
18 years ago

Patch border radius for webkit

@iammattthomas
18 years ago

Patch border radius for webkit

#3 @sambauers
18 years ago

It might be best to future proof border-radius declarations using this order...

-moz-border-radius: XXX
-khtml-border-radius: XXX
-webkit-border-radius: XXX
border-radius: XXX

For now Firefox picks up the first, Konqueror picks up the second, Safari picks up the second or third and in time they (and hopefully others) will all pick up the last CSS3 "standard" one.

#4 @ryan
18 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [6909]) Add webkit border radius. Props mt. fixes #5906

#5 @ryan
18 years ago

Missed sambauers comment before committing. Reopen if we want to change this.

#6 @matt
18 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Yeah let's standardize on that that.

#7 @lloydbudd
18 years ago

  • Keywords sambauers added
  • Milestone changed from 2.6 to 2.5

@iammattthomas
18 years ago

Patch reflects sambauers suggestion for specifying radiuses

@iammattthomas
18 years ago

Patch reflects sambauers suggestion for specifying radiuses

#8 @iammattthomas
18 years ago

Attached patches that specify radius as sambauers suggested above.

#9 @iammattthomas
18 years ago

  • Keywords has-patch added; sambauers removed

#10 @ryan
18 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [6917]) Border radius changes from mt. fixes #5906

Note: See TracTickets for help on using tickets.