Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #59086, comment 24


Ignore:
Timestamp:
09/04/2023 07:35:59 PM (12 months ago)
Author:
sabernhardt
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #59086, comment 24

    initial v1  
    1 Instead of enqueuing the editor script conditionally, as suggested on #59090, I simply removed it from the styles function. [https://github.com/WordPress/twentytwenty/issues/573 Issue 573] identified the Squared style as unnecessary and potentially confusing because it is the same as the Default style. However, experiencing that minor problem would require multiple conditions:
    2 1. updating the site to an upcoming version of Twenty Twenty;
     1Instead of enqueuing the editor script conditionally, as suggested on #59090, I simply removed it from the styles function. [https://github.com/WordPress/twentytwenty/issues/573 Issue 573] identified the Squared style as unnecessary and potentially confusing because it is the same as the Default style. However, experiencing that confusion would require multiple conditions:
     21. updating the site to use an upcoming version of Twenty Twenty;
    332. keeping the WordPress version at 5.0, 5.1 or 5.2; and
    443. creating or editing a Button block link, checking the sidebar, and expanding the Styles settings to find the extra option there.