#59101 closed defect (bug) (duplicate)
Twenty Fourteen: Improve various globals documentation, as per docblock standards.
Reported by: | upadalavipul | Owned by: | audrasjb |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch |
Focuses: | docs | Cc: |
Description
I have reviewed the Twenty Fourteen theme file code and found some of the files need to be improved with function commenting code. Please check the below files list.
File's
- wp-content/themes/twentyfourteen/functions.php
- wp-content/themes/twentyfourteen/inc/back-compat.php
- wp-content/themes/twentyfourteen/inc/customizer.php
- wp-content/themes/twentyfourteen/inc/widgets.php
Attachments (5)
Change History (8)
#1
@
14 months ago
- Keywords changes-requested has-patch added
- Owner set to audrasjb
- Status changed from new to reviewing
#2
@
14 months ago
Thanks for the new patch but your forgot to fix the related indentation issue (too many spaces before and after the name of the variable).
#3
@
9 months ago
- Keywords changes-requested removed
- Milestone Awaiting Review deleted
- Resolution set to duplicate
- Status changed from reviewing to closed
Thanks for the patches. The $content_width
variable only needed one space before and after it in widgets.php
, but the same function also uses $more
.
I combined this with other global documentation for themes on #58715, so let's continue the discussion on that ticket.
Note: See
TracTickets for help on using
tickets.
Hello and thanks for the patch proposal,
There is a small indentation issue in
twentyfourteen/inc/widgets.php
: you should have an empty line beetween@since
and$global
lines, and then the indentation of the@global
line should be different :)