Context Navigation

← Previous Ticket
Next Ticket →

#59101 reviewing defect (bug)

Twenty Fourteen: Improve various globals documentation, as per docblock standards.

Reported by:	upadalavipul	Owned by:	audrasjb
Milestone:	Awaiting Review	Priority:	normal
Severity:	normal	Version:
Component:	Bundled Theme	Keywords:	changes-requested has-patch
Focuses:	docs	Cc:

Description

I have reviewed the Twenty Fourteen theme file code and found some of the files need to be improved with function commenting code. Please check the below files list.

File's

wp-content/themes/twentyfourteen/functions.php
wp-content/themes/twentyfourteen/inc/back-compat.php
wp-content/themes/twentyfourteen/inc/customizer.php
wp-content/themes/twentyfourteen/inc/widgets.php

Attachments (5)

59101.patch (3.5 KB) - added by upadalavipul 4 months ago.
59101.2.patch (3.5 KB) - added by rajinsharwar 4 months ago.: Adding a lne between the global and since
59101.3.patch (3.5 KB) - added by upadalavipul 4 months ago.: updated space and line
59101-twentytwenty.patch (448 bytes) - added by viralsampat 4 months ago.: I have checked another theme and founds few file. Here, I have added its patch.
59101-twentyfifteen.patch (2.8 KB) - added by viralsampat 4 months ago.: I have checked another theme and founds few file. Here, I have added its patch.

Download all attachments as: .zip

Change History (7)

@upadalavipul
4 months ago

Attachment 59101.patch added

#1 @audrasjb
4 months ago

Keywords changes-requested has-patch added
Owner set to audrasjb
Status changed from new to reviewing

Hello and thanks for the patch proposal,

There is a small indentation issue in twentyfourteen/inc/widgets.php: you should have an empty line beetween @since and $global lines, and then the indentation of the @global line should be different :)