WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#5911 closed defect (bug) (fixed)

Media Library updates

Reported by: andy Owned by: ryan
Milestone: 2.5 Priority: normal
Severity: normal Version: 2.5
Component: Administration Keywords: media has-patch
Focuses: Cc:

Description

Target: bring the Media Library page into line with the Happy Cog mockup.

Patches: coming in bursts.

Attachments (35)

5911-1.diff (24.8 KB) - added by andy 6 years ago.
5911-2.diff (552 bytes) - added by andy 6 years ago.
Fix the Delete button AYS
5911-3.diff (49.9 KB) - added by andy 6 years ago.
images.zip (26.9 KB) - added by andy 6 years ago.
file icons for wp-includes/images
5911-4.diff (3.7 KB) - added by andy 6 years ago.
update mime-to-icon matching
5911-5.diff (639 bytes) - added by andy 6 years ago.
get filename from function instead of guid. fixes h-scroll caused by bad guid.
5911-6.diff (22.9 KB) - added by andy 6 years ago.
incremental changes to bring behavior up to latest wireframes
5911-7.diff (484 bytes) - added by andy 6 years ago.
fix overuse of default mime icon
5911-8.diff (652 bytes) - added by andy 6 years ago.
re-shuffle mp4/m4a file type matches
5911-9.diff (9.1 KB) - added by andy 6 years ago.
first pass at Media Library uploader tab
5911-10.diff (489 bytes) - added by andy 6 years ago.
remove debug cruft
5911-11.diff (599 bytes) - added by andy 6 years ago.
set swfupload max file size to match php ini
5911-12.diff (36.6 KB) - added by andy 6 years ago.
Button Revival!
5911-13.diff (7.7 KB) - added by andy 6 years ago.
error improvements, localization, and icon improvements -- please do not commit before new icons arrive in wp-includes/images/crystal
5911-14.diff (433 bytes) - added by andy 6 years ago.
Fix table styling
5911-15.diff (946 bytes) - added by andy 6 years ago.
Revive and filter "Add media:" text beside upload buttons
5911-16.diff (7.6 KB) - added by andy 6 years ago.
Improve upload_max_filesize error. Improve error display for long messages. New uploads now added to bottom, not top. Fix align class. Remove redundant header text.
5911-17.diff (9.2 KB) - added by andy 6 years ago.
Fix insert, gallery, sizing, type queries, errors, thumbs, type fallback.
5911-18.diff (452 bytes) - added by andy 6 years ago.
fix missing thumbnail radio button for inserting into post
5911-19.diff (609 bytes) - added by andy 6 years ago.
use new colors stylesheet
5911-20.diff (2.4 KB) - added by andy 6 years ago.
fix icons
5911-21.diff (1.3 KB) - added by andy 6 years ago.
fix invisible delete links (now with media-upload iframe body id)
5911-22.diff (1.5 KB) - added by andy 6 years ago.
more thumbnail fixes
5911-23.diff (1.2 KB) - added by andy 6 years ago.
remove ugliness from default attachment template
5911-24.diff (6.5 KB) - added by andy 6 years ago.
5911-25.diff (1.2 KB) - added by andy 6 years ago.
translate "Crunching..."
5911-26.diff (4.2 KB) - added by andy 6 years ago.
add Save button and fix tab+type breakage
5911-27.diff (5.4 KB) - added by andy 6 years ago.
"Deleted" message
5911-28.diff (5.8 KB) - added by andy 6 years ago.
use array(width, height) sizes in new image funcs
5911-29.diff (18.9 KB) - added by andy 6 years ago.
last patch on this ticket: remove obviously unreachable code
default-media-icon-size.png (22.9 KB) - added by iammattthomas 6 years ago.
Showing bad effects of min-height: 40px; on the thumbnail/icon
5911-rel.diff (2.6 KB) - added by andy 6 years ago.
add rel attrs to attachment links inserted from uploader
5911-delpretty.diff (4.0 KB) - added by andy 6 years ago.
pretty delete animation
5911-iconpretty.diff (843 bytes) - added by andy 6 years ago.
fix squashed icons and use 80x60 thumbs
5911-master.diff (4.8 KB) - added by andy 6 years ago.

Download all attachments as: .zip

Change History (75)

andy6 years ago

comment:1 ryan6 years ago

(In [6910]) Media Library design updates from Andy. see #5911

comment:2 ryan6 years ago

  • Owner changed from ryan to andy

andy6 years ago

Fix the Delete button AYS

comment:3 andy6 years ago

  • Owner changed from andy to ryan

comment:4 ryan6 years ago

(In [6941]) Fix media delete nonce. Props andy. see #5911

andy6 years ago

andy6 years ago

file icons for wp-includes/images

comment:5 ryan6 years ago

(In [6974]) Media library work from andy. see #5911

andy6 years ago

update mime-to-icon matching

andy6 years ago

get filename from function instead of guid. fixes h-scroll caused by bad guid.

comment:6 ryan6 years ago

(In [7036]) update mime-to-icon matching and get filename from function instead of guid. Props andy. see #5911

andy6 years ago

incremental changes to bring behavior up to latest wireframes

comment:7 ryan6 years ago

(In [7043]) Media upload updates from andy. see #5911

andy6 years ago

fix overuse of default mime icon

andy6 years ago

re-shuffle mp4/m4a file type matches

comment:8 ryan6 years ago

(In [7045]) fix overuse of default mime icon and re-shuffle mp4/m4a file type matches. Props andy. see #5911

andy6 years ago

first pass at Media Library uploader tab

comment:9 ryan6 years ago

(In [7062]) Add media library uploader tab. Props andy. see #5911

andy6 years ago

remove debug cruft

andy6 years ago

set swfupload max file size to match php ini

comment:10 ryan6 years ago

(In [7067]) remove debug cruft and set swfupload max file size to match php ini. Props andy. see #5911

andy6 years ago

Button Revival!

comment:11 ryan6 years ago

(In [7092]) Media library updates from andy. see #5911

andy6 years ago

error improvements, localization, and icon improvements -- please do not commit before new icons arrive in wp-includes/images/crystal

comment:12 ryan6 years ago

(In [7100]) Media Library updates from andy. see #5911

andy6 years ago

Fix table styling

andy6 years ago

Revive and filter "Add media:" text beside upload buttons

comment:13 matt6 years ago

(In [7151]) Table styling and "add media" label. See #5911. Hat tip: andy.

andy6 years ago

Improve upload_max_filesize error. Improve error display for long messages. New uploads now added to bottom, not top. Fix align class. Remove redundant header text.

comment:14 ryan6 years ago

(In [7160]) Improve upload_max_filesize error. Improve error display for long messages. New uploads now added to bottom, not top. Fix align class. Remove redundant header text. Props andy. see #5911

andy6 years ago

Fix insert, gallery, sizing, type queries, errors, thumbs, type fallback.

comment:15 ryan6 years ago

(In [7172]) Fix insert, gallery, sizing, type queries, errors, thumbs, type fallback. Props andy. see #5911

andy6 years ago

fix missing thumbnail radio button for inserting into post

comment:16 ryan6 years ago

(In [7177]) fix missing thumbnail radio button for inserting into post. Props andy. see #5911

comment:17 westi6 years ago

  • Severity changed from major to blocker

Making a release blocker - we should close this when we are happy with the media library.

andy6 years ago

use new colors stylesheet

comment:18 westi6 years ago

(In [7185]) Use the new colours stylesheet for the media library. See #5911 props andy.

andy6 years ago

fix icons

comment:19 matt6 years ago

(In [7212]) Icon fixes. See #5911; hat tip: andy.

andy6 years ago

fix invisible delete links (now with media-upload iframe body id)

comment:20 matt6 years ago

(In [7213]) Invisible ink delete links. See #5911. Also some old school colors, half-way done.

andy6 years ago

more thumbnail fixes

comment:21 matt6 years ago

(In [7218]) More attachment thumbnail fixes, see #5911. Hat tip: andy.

andy6 years ago

remove ugliness from default attachment template

andy6 years ago

comment:22 matt6 years ago

(In [7222]) Better media attachment template. See #5911. Hat tip: andy.

andy6 years ago

translate "Crunching..."

andy6 years ago

add Save button and fix tab+type breakage

comment:23 matt6 years ago

(In [7228]) See #5911. Hat tip: andy.

andy6 years ago

"Deleted" message

comment:24 ryan6 years ago

(In [7256]) media handling fixes from andy. see #5911

andy6 years ago

use array(width, height) sizes in new image funcs

comment:25 ryan6 years ago

(In [7263]) Image fixes from andy. see #5911

comment:26 iammattthomas6 years ago

I just noticed this, but patch 5911-14.diff in [7151] squishes the media icons (60px tall) into a max-height of 40px.

If it's necessary for image thumbnails, a class should be applied to thumbnails that gives them the max-height. Or, a class could be applied to file icons that gives them a height of 60px.

comment:27 westi6 years ago

Now we have a funky media library that works a dream do we still need to keep wp-admin/includes/upload.php as it's not referenced by any WordPress code.

If so I guess we should make it as deprecated so we can remove it later.

comment:28 KirkM6 years ago

I'm hoping this is the correct place for this. In my testing I've found a problem with the current Media Library. It seems to have been around for the last few revisions. I've compared two different test sites below that exhibit the same problem.

In the "Manage/MediaLibrary", when selecting any link in the "Media"
column brings up the selected image's edit page as usual. At that point "Settings",
"Plugins" and "Users" disappears from the top right of page and the
following warning is displayed at the bottom of the page:

Warning*: Cannot modify header information - headers already sent by
(output started at
/home/longmead/public_html/just-thinkin/wp-admin/admin-header.php:26) in
*/home/longmead/public_html/just-thinkin/wp-includes/pluggable.php* on
line *688

All plugins are deactivated during this test.

On my other test site currently running on r2998 the same thing occurs
with the exception of slight change in the warning (different line #):

*Warning*: Cannot modify header information - headers already sent by
(output started at
/home/longmead/public_html/just-thinkin/wp25-test/wp-admin/admin-header.php:26)
in
*/home/longmead/public_html/just-thinkin/wp25-test/wp-includes/pluggable.php*
on line *687

Again, no plugins activated.

I'm to light yet on the ins and outs of the Wordpress code to troubleshoot this myself.

comment:29 follow-up: KirkM6 years ago

Correction to my last comment. In the first example, that site is running r7331.

comment:30 in reply to: ↑ 29 KirkM6 years ago

Replying to KirkM:

Correction to my last comment. In the first example, that site is running trunk build r7331 and in the second example the trunk build is r7298.

This may be related to ticket #6206

andy6 years ago

last patch on this ticket: remove obviously unreachable code

comment:31 ryan6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [7347]) Remove old upload files. props andy. fixes #5911

comment:32 bomberstudios6 years ago

  • Priority changed from high to normal
  • Resolution fixed deleted
  • Severity changed from blocker to normal
  • Status changed from closed to reopened
  • Type changed from enhancement to defect

As of r7355, upload.php is still linked from some pages in the admin area (i.e: Manage » Media Library)

I'm reopening the ticket in the hopes that either this file comes back or the link in edit.php is updated to whatever replaces upload.php

comment:33 westi6 years ago

(In [7356]) Restore upload.php as we really need it. See #5911.

comment:34 westi6 years ago

(In [7357]) Delete the correct upload.php. See #5911 props andy.

comment:35 westi6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

done

iammattthomas6 years ago

Showing bad effects of min-height: 40px; on the thumbnail/icon

comment:36 iammattthomas6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

It may have been overlooked, but I mentioned previously that the min-height of 40px needs to be adjusted as it's unnaturally squashing the media library icons. See screenshot.

andy6 years ago

add rel attrs to attachment links inserted from uploader

andy6 years ago

pretty delete animation

andy6 years ago

fix squashed icons and use 80x60 thumbs

andy6 years ago

comment:37 ryan6 years ago

(In [7466]) pretty delete animation, fix squashed icons and use 80x60 thumbs, add rel attrs to attachment links inserted from uploader. Props andy. see #5911

comment:38 technosailor6 years ago

For a brief few hours on Saturday, I was pleased to see a tags field added to the attachment editing page. It's gone now and I keep hoping it will come back. Can we get that back? Please?

comment:39 DD326 years ago

A comment on a blog post of mine:

also if I go to manage => media library then below “appears with” => it says: “no title” I click on no title, assuming I could edit its title, and get this error:

You attempted to edit a post that doesn’t exist. Perhaps it was deleted?

the url changes to: http://pacura.ru/wordpress/wp-admin/post.php?action=edit&post=-1206700048

it seems the media library tries to edit a post?

I can reproduce it on the latest Trunk too.

Create a new draft, attach an image, make sure it saves, Head over to the Manage Media library, the post link on the Image "Appears with" directs to the Draft post ID, not the real post id.

comment:40 ryan6 years ago

  • Milestone changed from 2.6 to 2.5
  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.