Make WordPress Core

Opened 11 months ago

Last modified 9 months ago

#59112 new defect (bug)

Plugin Dependencies design feedback

Reported by: afragen's profile afragen Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords: needs-design-feedback
Focuses: ui Cc:

Description

As discussed by @azaozz in Slack there is some outstanding discussion regarding the final thoughts on design for the Plugin Dependencies feature, #22316 and PR 3032.

There are still some outstanding issues on re-engineering the More details modal that will be discussed in a separate ticket.

This ticket was created to discuss the further design elements that may be needed for this feature. I do not believe that it is a block to the feature being committed and I believe that is also the opinion of @azaozz and @costdev.

Attachments (5)

teccc-add-plugins.png (267.1 KB) - added by afragen 11 months ago.
From the Add Plugins page
plugins-page.png (45.8 KB) - added by afragen 11 months ago.
From the dashboard plugins page
plugin-page-requires.png (45.3 KB) - added by afragen 11 months ago.
Plugin that requires another, unmet dependency
plugins-page-required-by.png (97.5 KB) - added by afragen 11 months ago.
Plugins page, installed and not activated dependency
59112-mock.jpg (88.2 KB) - added by kebbet 11 months ago.

Download all attachments as: .zip

Change History (13)

@afragen
11 months ago

From the Add Plugins page

@afragen
11 months ago

From the dashboard plugins page

@afragen
11 months ago

Plugin that requires another, unmet dependency

@afragen
11 months ago

Plugins page, installed and not activated dependency

This ticket was mentioned in Slack in #core-upgrade-install by afragen. View the logs.


11 months ago

This ticket was mentioned in Slack in #core by afragen. View the logs.


11 months ago

#3 follow-up: @kebbet
11 months ago

Great start, I'm thinking color codes on the ”Plugins" table for requirements met or not, green/red notice colors. Maybe the same style as the ”Add Plugins” page.
And we need to think through the handheld styles and layouts as well. See mockup.

@kebbet
11 months ago

#4 @afragen
11 months ago

Thanks @kebbet. I will say that the design also needs to account for multiple dependencies.

#5 in reply to: ↑ 3 ; follow-up: @justlevine
11 months ago

Replying to kebbet:

I'm thinking color codes on the ”Plugins" table for requirements met or not, green/red notice colors. Maybe the same style as the ”Add Plugins” page.

Personally majorly against color codes if they're not giving you actionable information (i.e. red highlighting a _failed_ activation), and think this particular will just add cognitive load with no user-facing benefit.

  • In any plugin ecosystem build (e.g. Woo, TEC, Gravity Forms), most the installed plugins are dependencies, so now 2 thirds of your plugin page has distracting green highlights, even though nothing is actionable.
  • The red highlight for bad states aren't _as bad_ as the green ones,but still pretty ineffectual. Unless the plugin failed activation, then the disabled 'Activate' button conveys the issue without masquerading as a live error state (what the red notice scheme is currently usually used for). I could see maybe using a red-colored icon before the notice, but even that feels strongly like visual clutter.

#6 in reply to: ↑ 5 @ashikur698
9 months ago

I think it's ideal to add the red highlighter as it'll grab the attention right away that the plugin requires another plugin to run.
Replying to justlevine:

Replying to kebbet:

I'm thinking color codes on the ”Plugins" table for requirements met or not, green/red notice colors. Maybe the same style as the ”Add Plugins” page.

  • The red highlight for bad states aren't _as bad_ as the green ones,but still pretty ineffectual. Unless the plugin failed activation, then the disabled 'Activate' button conveys the issue without masquerading as a live error state (what the red notice scheme is currently usually used for). I could see maybe using a red-colored icon before the notice, but even that feels strongly like visual clutter.

This ticket was mentioned in Slack in #core by jorbin. View the logs.


9 months ago

#8 @jorbin
9 months ago

  • Milestone changed from Awaiting Review to Future Release
  • Version trunk deleted

Removing trunk since this hasn't landed in core yet and also moving this to the Future Release milestone so that this ticket appears in the correct reports.

Note: See TracTickets for help on using tickets.