Opened 14 months ago
Closed 14 months ago
#59127 closed enhancement (duplicate)
YODA update and strict comparison
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | Priority: | normal | |
| Severity: | normal | Version: | 6.4 |
| Component: | Filesystem API | Keywords: | has-patch |
| Focuses: | coding-standards | Cc: |
Description
YODA update and strict comparison in wp-admin/includes/class-ftp.php
Change History (2)
This ticket was mentioned in PR #5022 on WordPress/wordpress-develop by @saratheonline.
14 months ago
#1
- Keywords has-patch added
#2
@
14 months ago
- Milestone Awaiting Review deleted
- Resolution set to duplicate
- Status changed from new to closed
Hi there, welcome to WordPress Trac! Thanks for the ticket.
The FTP classes (class-ftp.php, class-ftp-pure.php, class-ftp-sockets.php) can be considered an "adopted" external library which is no longer supported upstream, see comment:9:ticket:24780.
That said, I think we should still minimize changes to them, as they don't need to follow WordPress coding standards and are excluded from WPCS checks, see comment:8:ticket:45967.
If that is ever reconsidered, they would need a lot more changes than proposed here.
This was previously raised in #45967, let's continue the discussion there.
YODA and strict comparison.
Trac ticket: https://core.trac.wordpress.org/ticket/59127