WordPress.org
Get WordPress

Make WordPress Core

Opened 21 months ago

Closed 3 months ago

#59133 closed enhancement (fixed)

Collapse Menu title consistency

Reported by: alireyad's profile alireyad Owned by: audrasjb's profile audrasjb
Milestone: 6.8 Priority: normal
Severity: normal Version:
Component: Administration Keywords: changes-requested has-patch has-screenshots
Focuses: ui, administration Cc:

Description

I notice a thing that every menu and submenu title in administration area are capitalize but Collapse menu title is different. I think it could be capitalize also.

Attachments (2)

screenshot.png​ (104.4 KB) - added by alireyad 21 months ago.
Attachment of issue
title-fix.patch​ (712 bytes) - added by amimulihsanmahdi 3 months ago.
Menu-title-fix

Download all attachments as: .zip

Change History (12)

@alireyad
21 months ago

Attachment of issue

This ticket was mentioned in ​PR #5029 on ​WordPress/wordpress-develop by ​bijit027.
21 months ago #1

  • Keywords has-patch added

#2 @bijit027
21 months ago

I have checked the Menu Collapse consistency issue. I have resolved this issue by modifying the name of the collapsed menu from (Collapse menu) to (Collapse Menu) in the menu-header.php file.

#3 @alireyad
21 months ago

  • Keywords has-screenshots added

Thanks @bijit027 for creating PR.

​@alireyad commented on ​PR #5029:
21 months ago #4

Thanks @bijit027 for the PR. Please, don't add irrelevant code which is not related to this PR.

@amimulihsanmahdi
3 months ago

Menu-title-fix

#5 follow-up: @amimulihsanmahdi
3 months ago

I saw another ticket got approved with the similar case: https://core.trac.wordpress.org/ticket/62971

This one should get approved as well. I have added my patch in the attachment section.

#6 in reply to: ↑ 5 @csesumonpro
3 months ago

I have already tested title-fix.patch it's working perfectly without issue.

#7 @audrasjb
3 months ago

  • Milestone changed from Awaiting Review to 6.8
  • Owner set to audrasjb
  • Status changed from new to reviewing

Self assigning for review

#8 @audrasjb
3 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 59847:

Administration: Capitalize "Collapse Menu" string for better consistency.

This changeset brings more consistency by capitalizing the "Collapse Menu" string localted in the main admin menu.

Props alireyad, bijit027, amimulihsanmahdi, csesumonpro.
Fixes #59133.

#9 @audrasjb
3 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Quoted from @swissspidy on Slack:

What about the "Collapse Main menu" string?

Reopening for a quick follow-up commit :)

#10 @audrasjb
3 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 59849:

Administration: Capitalize "Collapse Main Menu" aria-label string for better consistency.

Follow-up to [59847].

Props swissspidy.
Fixes #59133.

Note: See TracTickets for help on using tickets.