Plugin Search Bug: Plugin Search Page (%20 is being added to the searched keyword on page refresh)

[nithi22]

There is a strange bug inside "Add plugins page" while searching for a plugin.
If the search string has a space, then reloading the page will replace the space with a "%20". This is inside the search input field.

Environment

• WordPress: 6.3
• PHP: 8.2.0
• Server: Apache/2.4.54 (Unix) OpenSSL/1.0.2u PHP/8.2.0 mod_wsgi/3.5 Python/2.7.18 mod_fastcgi/mod_fastcgi-SNAP-0910052141 mod_perl/2.0.11 Perl/v5.30.1
• Database: mysqli (Server: 5.7.39 / Client: mysqlnd 8.2.0)
• Browser: Firefox 116.0 (macOS)
• Theme: Twenty Twenty-Three 1.0
• MU-Plugins: None activated
• Plugins:
  • WordPress Beta Tester 3.5.3

Steps to Reproduce

1. Access the WordPress backend.
2. Navigate to the Plugins-> Add New.
3. In the search box, enter keywords with space, e.g., "awsm team"
4. Press Enter or click the Search button.
5. Refresh the page.
6. Observe that the "%20" is being added to the searched keyword on page refresh(awsm%20team).

Expected Results

1. Search input field should not contain "%20"

Actual Results

1. %20 added to spaces inside the search input field

[adhun]

This patch will show the decoded search keyword on plugins install page.

Fix : Plugin Search Bug: Plugin Search Page (%20 is being added to the searched keyword on page refresh)

Trac ticket: https://core.trac.wordpress.org/ticket/59143

[nithi22]

After the page refresh

[nithi22]

Test Report

This report validates that the indicated patch addresses the issue.

Patch tested: ​https://github.com/WordPress/wordpress-develop/pull/5035

Environment

• WordPress: 6.3
• PHP: 8.2.0
• Server: Apache/2.4.54 (Unix) OpenSSL/1.0.2u PHP/8.2.0 mod_wsgi/3.5 Python/2.7.18 mod_fastcgi/mod_fastcgi-SNAP-0910052141 mod_perl/2.0.11 Perl/v5.30.1
• Database: mysqli (Server: 5.7.39 / Client: mysqlnd 8.2.0)
• Browser: Firefox 116.0 (macOS)
• Theme: Twenty Twenty-Three 1.0
• MU-Plugins: None activated
• Plugins:
  • WordPress Beta Tester 3.5.3

Actual Results

1. ✅ Issue resolved with patch.

[nithi22]

Before patch

[nithi22]

After patch

[deepakvijayan]

I tested this on WordPress 6.3
The issue seems to be gone after applying the patch.

Below is the test report. Attaching images for reference as well.

Patch tested: ​https://github.com/WordPress/wordpress-develop/pull/5035

Environment

• WordPress: 6.3
• PHP: 8.2.0
• Server: Apache/2.4.54 (Unix) OpenSSL/1.0.2u PHP/8.2.0 mod_wsgi/3.5 Python/2.7.18 mod_fastcgi/mod_fastcgi-SNAP-0910052141 mod_perl/2.0.11 Perl/v5.30.1
• Database: mysqli (Server: 5.7.39 / Client: mysqlnd 8.2.0)
• Browser: Firefox 116.0 (macOS)
• Theme: Twenty Twenty-Three 1.0
• MU-Plugins: None activated
• Plugins:
  • WordPress Beta Tester 3.5.3

Actual Results

1. ✅ Issue resolved with patch.

[zunaid321]

Test Report

This report validates that the indicated patch addresses the issue.

Patch tested: ​https://github.com/WordPress/wordpress-develop/pull/5035

Environment

• OS: Windows 11 (22H2)
• Web Server: nginx/1.25.1
• PHP: 7.4.33
• WordPress: 6.4-alpha-56267-src
• Browser: Chrome Version 113.0.5672.126 (Official Build) (64-bit)
• Theme: Twenty Twenty-Three

Before Applying The Patch

• Followed the instructions of @nithi22
• ❌ "%20" does show up.

After Applying The Patch

• Followed the same instructions.
• ✅ "%20" does not show up anymore.

Supplemental Artifacts

Before: ​https://prnt.sc/ISXSBaxaQPD1
After: ​https://prnt.sc/b9iG1O1Lonri

[iammehedi1]

Test Report

This report validates that the indicated patch addresses the issue.

Patch tested: ​https://github.com/WordPress/wordpress-develop/pull/5035

Environment

• OS: Windows 11 Pro (22H2)
• Web Server: nginx/1.25.1
• PHP: 7.4.33
• WordPress: 6.4-alpha-56267-src
• Browser: Chrome Version 116.0.5845.98 (Official Build) (64-bit)
• Theme: Twenty Twenty-Three

Prior to Applying the Patch

• Followed the provided guidelines of @nithi22
• ❌ '%20' appears if we refresh the plugin page after searching

After Applying The Patch

• Followed the same guidelines
• ✅ '%20' doesn't show up anymore - it's FIXED

Screenshots

Before: ​https://prnt.sc/kEipuoID9XPz

After: ​https://prnt.sc/ndyonHKKmAem

[swissspidy]

Originally reported at ​https://wordpress.slack.com/archives/C02RQBWTW/p1676398669968419

Probably a regression from r53844, which was then thought to be fixed in #57174 / r54904 but that only affected the installed plugins search.

[swissspidy]

In 56446:

Plugins: Correctly display spaces in new plugins search results.

Ensures the encoded search term in the input field is correctly decoded again.

Follow-up to [53844] and [54904].

Props adhun, nithi22, huzaifaalmesbah, deepakvijayan, zunaid321, iammehedi1.
Fixes #59143.

Fixed in https://core.trac.wordpress.org/changeset/56446