WordPress.org

Make WordPress Core

Opened 13 years ago

Closed 4 years ago

Last modified 4 years ago

#5915 closed defect (bug) (wontfix)

Same problem as in #252: apop broken if zero occurs in banner in 2.3.3 class-pop3.php

Reported by: ASonno Owned by: westi
Milestone: Priority: normal
Severity: normal Version: 2.3.3
Component: Mail Keywords: close
Focuses: Cc:

Description

While extracting the banner (function parse_banner) in preparation for apop, the empty method is called on $digit which when zero returns false and hence doesn't get put into the resultant $banner.

Example parse_banner reply with <14649.123343777@…> but the string was "+OK ready <14649.1203343777@…>"
or another example
"+OK ready <14649.1203343777@…>" and $pop3->parse_banner give back <14419.12334323@…>

then a md5($AuthString) must fail, because the 0 is significant by apop.

I put a workaround at http://www.babsi.de/silentapop/, that does it for me, but this touch also wp-main.php

Attachments (1)

pop3.zerostrip.patch (582 bytes) - added by t.baboon 12 years ago.

Download all attachments as: .zip

Change History (13)

#1 @t.baboon
12 years ago

  • Keywords has-patch needs-testing added

Here is a patch.

-- t.baboon

#2 @Denis-de-Bernardy
12 years ago

  • Component changed from General to Mail
  • Owner anonymous deleted

#3 follow-up: @westi
11 years ago

  • Component changed from Mail to Blog by Email
  • Milestone changed from 2.9 to Future Release
  • Owner set to westi
  • Status changed from new to accepted

Moving all blog-by-email bugs to a seperate component and out of 2.9.

This will all be address by a new canonical blog-by-email plugin which is under development and will hopefully be available by the time 2.9 is released.

#4 @nacin
7 years ago

  • Component changed from Blog by Email to Mail

#5 in reply to: ↑ 3 ; follow-up: @ericlewis
6 years ago

Replying to westi:

This will all be address by a new canonical blog-by-email plugin which is under development and will hopefully be available by the time 2.9 is released.

Did this happen?

#6 in reply to: ↑ 5 ; follow-up: @helen
6 years ago

Replying to ericlewis:

Replying to westi:

This will all be address by a new canonical blog-by-email plugin which is under development and will hopefully be available by the time 2.9 is released.

Did this happen?

Not before 2.9 I guess, but codebykat did a plugin for her OPW internship: https://github.com/codebykat/wp-post-by-email

If you want to figure out if/how we can move that out of core, that could be cool.

#7 @ericlewis
6 years ago

  • Keywords needs-patch added; APOP Blogg by Email has-patch needs-testing removed

#8 @ericlewis
6 years ago

  • Keywords needs-patch removed

We can take a similar approach to the decommissioning of links. Leave the functionality and UI, hide UI if it isn't being used.

#9 in reply to: ↑ 6 @SergeyBiryukov
6 years ago

Replying to helen:

If you want to figure out if/how we can move that out of core, that could be cool.

See #22942.

#10 @cbutlerjr
5 years ago

  • Keywords close added

This is a pretty old ticket, but looking at the class, it evidently still exists as a possible issue?

This particular class is one of those deeply buried, rarely touched kind of things. Maybe it's just me, but I can't even find where it is actually used anymore.

Is this still a relevant ticket? Should it be closed as wontfix?

#11 @cbutlerjr
4 years ago

  • Resolution set to wontfix
  • Status changed from accepted to closed

Assuming a focus on removing Post by Email from core (#22942), recommending this be closed.

#12 @netweb
4 years ago

  • Milestone Future Release deleted
Note: See TracTickets for help on using tickets.