Make WordPress Core

Opened 6 years ago

Last modified 2 months ago

#5915 accepted defect (bug)

Same problem as in #252: apop broken if zero occurs in banner in 2.3.3 class-pop3.php

Reported by: ASonno Owned by: westi
Milestone: Future Release Priority: normal
Severity: normal Version: 2.3.3
Component: Mail Keywords: APOP Blogg by Email has-patch needs-testing
Focuses: Cc:


While extracting the banner (function parse_banner) in preparation for apop, the empty method is called on $digit which when zero returns false and hence doesn't get put into the resultant $banner.

Example parse_banner reply with <14649.123343777@…> but the string was "+OK ready <14649.1203343777@…>"
or another example
"+OK ready <14649.1203343777@…>" and $pop3->parse_banner give back <14419.12334323@…>

then a md5($AuthString) must fail, because the 0 is significant by apop.

I put a workaround at http://www.babsi.de/silentapop/, that does it for me, but this touch also wp-main.php

Attachments (1)

pop3.zerostrip.patch (582 bytes) - added by t.baboon 5 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 t.baboon5 years ago

  • Keywords has-patch needs-testing added

Here is a patch.

-- t.baboon

t.baboon5 years ago

comment:2 Denis-de-Bernardy5 years ago

  • Component changed from General to Mail
  • Owner anonymous deleted

comment:3 westi5 years ago

  • Component changed from Mail to Blog by Email
  • Milestone changed from 2.9 to Future Release
  • Owner set to westi
  • Status changed from new to accepted

Moving all blog-by-email bugs to a seperate component and out of 2.9.

This will all be address by a new canonical blog-by-email plugin which is under development and will hopefully be available by the time 2.9 is released.

comment:4 nacin2 months ago

  • Component changed from Blog by Email to Mail
Note: See TracTickets for help on using tickets.