register_block_type is not working with symbolic links

[antonlukin]

I try to register new block inside functions.php of my theme with register_block_type( DIR . '/build/speech' ); function.
block.json is located inside './build/speech' directory.

The block registered correctly, but files editorScript and editorStyle can't enqueue because of the symlinks problem.

$is_theme_block variable set to false while
$style_path_norm points to /srv/http/kedr.media/theme/public/blocks/build/help/index.css
$template_path_norm points to /srv/http/kedr.media/wordpress/wp-content/themes/kedr

​https://github.com/WordPress/WordPress/blob/106404bcbd2e8c19947b64691dd2dbadf0f02a47/wp-includes/blocks.php#L272

My theme is physically located on /srv/http/kedr.media/theme/public/ path, but WordPress core on /srv/http/kedr.media/wordpress/

This doesn't seem to be the best way to check if a block is part of a theme.

[spacedmonkey]

@antonlukin There are been changes to the block registration process in WP 6.4. It is possible that you could test the latest beta to see if that fixes the issue.

Trac ticket: https://core.trac.wordpress.org/ticket/59175

[spacedmonkey]

Pinging @audrasjb, as this is an area that they have looked at in the past. There is a draft PR with a fix.

[antonlukin]

I apologize for the delay, I'll try to check today with the latest patch

[antonlukin]

@spacedmonkey checked on 6.4. It works, thanks!

[spacedmonkey]

I believe it too late for 6.4, but maybe 6.4.1.

[maxpertici]

I encountered the same problem today and arrived at the same place (and solution). It would be very useful to support symbolic links for themes. Thanks for this PR.

[audrasjb]

Self assigning for testing/review 👀

[audrasjb]

I reproduced the issue and the patch fixes it.
I'm gonna commit it so it still have time to be tested during beta cycle.

By the way I'm wondering about directly including realpath() in wp_normalize_path() to avoid those issues in the future? (but that's for another ticket).

[audrasjb]

In 57675:

Editor: Allow symlinks in directories provided to get_block_asset_url().

This changeset allows using symbolic links for editorScript and editorStyle in register_block_type(). This adds realpath to template and stylesheet in get_block_asset_url() to ensure returning canonicalized absolute pathnames.

Follow-up to [56683].

Props antonlukin, spacedmonkey, maxpertici.
Fixes #59175.
See #58525.

committed in https://core.trac.wordpress.org/changeset/57675