Output of JS version of human_time_diff in the editor is not translated

[ramonopoly]

Currently the output of ​humanTimeDiff() in the editor is not translatable as it expects translated strings to pass to moment.js.

These strings must be passed in the relative object as per the ​moment.js locale settings model.

We need to update wp_default_packages_inline_scripts() to add relative time strings to the wp-date inline script.

Gutenberg PR: ​https://github.com/WordPress/gutenberg/pull/53931

Props to @oandregal for the original report: ​https://github.com/WordPress/gutenberg/issues/53888

This PR syncs the changes in:

• ​https://github.com/WordPress/gutenberg/pull/53931

Updates wp_default_packages_inline_scripts() to add relative time strings to the wp-date inline script.

This is so the ​JS version of ​human_time_diff can output translated strings.

It uses these translated strings in moment calculations. See the relevant model: ​https://momentjscom.readthedocs.io/en/latest/moment/07-customization/07-relative-time/

Trac ticket: https://core.trac.wordpress.org/ticket/59219

[audrasjb]

Thanks for the ticket and patch!
Marking for commit consideration.

Ps: removing i18n-change as this is only used late in the development cycle (after string freeze) to track potential string changes, as translators need to be notified.

Doesn't this also partially address https://core.trac.wordpress.org/ticket/47373?

What I don't understand is why this was first addressed in Gutenberg and not just directly in core 🤷 Seems like unnecessary duplicate work.

[swissspidy]

Looks like a duplicate of #47373

Doesn't this also partially address https://core.trac.wordpress.org/ticket/47373?

Oh, I wasn't aware of it. Thanks for sharing. I see the ticket is 4 years old, so thank you, @ramonjd, for addressing it! :)

What I don't understand is why this was first addressed in Gutenberg and not just directly in core 🤷 Seems like unnecessary duplicate work.

I already commented ​here, though it's perhaps worth re-sharing:

Gutenberg supports the last two WordPress releases. At the moment, WordPress 6.2 and WordPress 6.3. Even when/if the fix is released as part of WordPress 6.4, Gutenberg still has to support WordPress 6.3. I think it's worth enabling users to see the string in their language faster than 6.4 is available (and before they update).

[audrasjb]

In 56496:

Editor: Add relative time strings for the wp-date inline script output.

This changeset updates wp_default_packages_inline_scripts() to add relative time strings to the wp-date inline script, so the JS version of human_time_diff
can output translated strings.

Props ramonopoly, oandregal, swissspidy, manzoorwanijk, adrianduffell, Presskopp.
Fixes #59219, #47373.

committed in https://core.trac.wordpress.org/changeset/56496