Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #59226, comment 9


Ignore:
Timestamp:
08/29/2023 05:56:20 PM (11 months ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #59226, comment 9

    v1 v2  
    88> Looking at the two lists, I don't think any of the values is truly unsupported by `WP_Query`, it's more about adjusting the names, for example `post_modified_gmt` and `modified_gmt` should map to `modified` so that it works in `WP_Query` (the GMT value will be sorted just the same as the non-GMT value since they are just in a different timezone). It's trivial to add such logic, so let's do it for all previously supported orderby fields.
    99
    10 Sure, sounds like that'd work for fixing the `orderby`. If you think it is better to keep fixing back-compat problems, the new code will also need all possible tests to confirm old functionality and quirks are still supported.
     10Sure, sounds like that'd work for fixing the `orderby`. If you think it is better to keep fixing back-compat problems, the new code will also need all possible tests to confirm old functionality and quirks are still supported. Frankly I see few more places that look "suspicious" in that changeset. Keep in mind this code has been "fixed" many times and incrementally improved over 15 years :)