WordPress.org
Get WordPress

Make WordPress Core

Opened 15 months ago

Closed 15 months ago

Last modified 15 months ago

#59236 closed defect (bug) (fixed)

Incorrect names used for Site Health permission checks

Reported by: swissspidy's profile swissspidy Owned by: swissspidy's profile swissspidy
Milestone: 6.4 Priority: normal
Severity: normal Version: 6.1
Component: Site Health Keywords: has-patch
Focuses: rest-api Cc:

Description

As pointed out at ​https://github.com/WordPress/wordpress-develop/commit/6ff5bf856a5012526d7fadbbee01ed4ba1ee93e2#commitcomment-125792863, \WP_REST_Site_Health_Controller::validate_request_permission() is called with some incorrect check names that don't match the actual endpoint.

Change History (6)

​@swissspidy commented on ​PR #5109:
15 months ago #2

cc @manuelrod @felixarntz

​@mukesh27 commented on ​PR #5109:
15 months ago #3

The $this->validate_request_permission( 'debug_enabled' ) was introduce changeset 49154

#4 @swissspidy
15 months ago

  • Owner set to swissspidy
  • Resolution set to fixed
  • Status changed from new to closed

In 56489:

Site Health: fix check name used for REST API permission checks.

Updates the calls to permission validation calls for the directory-sizes and page-cache routes to actually match the route names.

Follow-up to r54043 and r49154.

Props szepeviktor.
Fixes #59236

​szepeviktor commented on ​PR #5109:
15 months ago #6

Thank you all the member of this flashmob! 🙃

Note: See TracTickets for help on using tickets.