WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#59254 closed defect (bug) (fixed)

Remove the Unused global variables in the wp-admin folder.

Reported by: upadalavipul Owned by: audrasjb
Priority: normal Milestone: 6.4
Component: General Version:
Severity: normal Keywords: has-patch commit
Cc: Focuses: coding-standards

Description

I have reviewed the code and found Unused global variables in some of the below files. Please check the below files:

Files:

  1. wp-admin/includes/class-wp-privacy-policy-content.php
  2. wp-admin/includes/ms.php
  3. wp-admin/includes/upgrade.php

Attachments (4)

59254.patch​ (1.8 KB ) - added by upadalavipul 3 years ago.
Patch added
59254.2.patch​ (1.1 KB ) - added by upadalavipul 3 years ago.
added more two files.
59254.3.patch​ (577 bytes ) - added by viralsampat 3 years ago.
I have checked above mentioned issue and founds another file. Here, I have added its patch.
59254.4.patch​ (1.4 KB ) - added by viralsampat 3 years ago.
I have checked above mentioned issue and founds another file. Here, I have added its patch.

Download all attachments as: .zip

Change History (8)

@upadalavipul
3 years ago

Patch added

#1 @audrasjb
3 years ago

  • Keywords has-patch commit added
  • Milestone Awaiting Review → 6.4
  • Owner set to audrasjb
  • Status new → accepted

These changes look good to me, thanks.

#2 @audrasjb
3 years ago

  • Resolution → fixed
  • Status accepted → closed

In 56499:

Coding Standards: Remove unused global variables in various /wp-admin/includes/ files.

Props upadalavipul.
Fixes #59254.

@upadalavipul
3 years ago

added more two files.

#3 @SergeyBiryukov
3 years ago

In 56504:

Media: Remove unused $is_IE and $is_opera globals in media_upload_form().

Follow-up to [27316].

Props upadalavipul.
See #59254.

#4 @SergeyBiryukov
3 years ago

In 56505:

Upgrade/Install: Remove unused globals in core_upgrade_preamble().

Follow-up to [49638].

Props upadalavipul.
See #59254.

@viralsampat
3 years ago

I have checked above mentioned issue and founds another file. Here, I have added its patch.

@viralsampat
3 years ago

I have checked above mentioned issue and founds another file. Here, I have added its patch.

Note: See TracTickets for help on using tickets.