WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 6 years ago

#5926 closed defect (bug) (fixed)

Settings > General should show current time and current example only correct half the year

Reported by: lloydbudd Owned by: ryan
Milestone: 2.8 Priority: normal
Severity: normal Version: 2.5
Component: General Keywords: has-patch
Focuses: Cc:

Description

Currently it reads:
Times in the blog should differ by [field] hours (Your timezone offset, for example -6 for Central Time.)

There are a few problems with this:

  1. Central Time is only -6 half the year because of day light savings time. I think it would be better to include the "current time" right there.
  1. UTC time being listed in am/pm makes it much harder to do addition/subtraction.
  1. The setting is in the context of the line above which is on its own row, and looks like a separate setting. Therefore should explicitly say the context, or I think better is not have a divider between them (ie be the same row).

ADDITIONAL DETAILS

The resulting style of using 2 <brs> and joining the rows isn't ideal, but it is the best of my limited abilities.

"Current time" is only correct when the page first loads. If it could be kept correct with some simply JavaScript that would be great.

Attachments (4)

5926.diff (1.5 KB) - added by lloydbudd 7 years ago.
pretty_offset.diff (1.9 KB) - added by ryan 7 years ago.
5926-tweaks.diff (1.7 KB) - added by lloydbudd 7 years ago.
5926-4.diff (2.1 KB) - added by lloydbudd 7 years ago.

Download all attachments as: .zip

Change History (11)

@lloydbudd7 years ago

@ryan7 years ago

comment:1 @ryan7 years ago

Patch changes the offset input to be a dropdown ranged from -12 to 12 in 30 minute increments. UTC time and offset time are displayed below the dropdown.

comment:2 @ryan7 years ago

I'm a dork and accidentally committed this in [6932]. Since it's there, check it out and see if you like it.

comment:3 @lloydbudd7 years ago

  • Keywords has-patch added

Thats great! So much better than it was, and so much better than I proposed.

I would like to tweak it even more still. I think it would benefit by being in the format that the person is familar with for readability and some other small tweaks:

  1. Like the results for the formats below it, the result should be bold (strong).
  1. For both lines show the date in the Date Format chosen. (Also remove code formatting.)
  1. Remove the seconds, not interesting or useful.
  1. Show UTC in 24-hr time, but the offset time in time format chosen.
  1. "Output:" from the formats should be removed.
  1. "UTC time" 'time' is redundant, and by removing it the text lines up better.
  1. Because it is user modifiable, I find it useful to show the result even if UTC (removed 'if ($current_offset)'). I don't think it is worth coding a custom phrase for this case.

Feel free to close as fixed, or to apply the patch.

@lloydbudd7 years ago

comment:4 @ryan7 years ago

  • Owner changed from anonymous to ryan

@lloydbudd7 years ago

comment:5 @lloydbudd7 years ago

5926-4.diff , turns it on its head for the best of all worlds (Including correction from #5988)

comment:6 @Denis-de-Bernardy6 years ago

  • Milestone changed from 2.9 to 2.8

fixed in 2.8, no?

comment:7 @ryan6 years ago

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.