Make WordPress Core

Opened 9 months ago

Closed 4 months ago

Last modified 4 months ago

#59278 closed defect (bug) (fixed)

Missing esc_attr() in class-custom-image-header.php

Reported by: nareshbheda's profile nareshbheda Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.5 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch
Focuses: coding-standards Cc:

Description

Found missing esc_attr() width and height in "wp-admin/includes/class-custom-image-header.php"

Change History (7)

@audrasjb commented on PR #5132:


9 months ago
#2

Thanks for the PR. FWIW there is at least one other occurrence in this file:

@nareshbheda commented on PR #5132:


9 months ago
#3

@audrasjb Thank you for the suggestion, I have applied your suggestion in the latest commit.

@kebbet commented on PR #5132:


9 months ago
#4

Why add escaping in line 341, it does not make sense @audrasjb?

#5 @SergeyBiryukov
4 months ago

  • Milestone changed from Awaiting Review to 6.5

#6 @SergeyBiryukov
4 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 57364:

Coding Standards: Add missing escaping in Custom_Image_Header::step_2().

Follow-up to [4673], [14907].

Props nareshbheda, audrasjb, kebbet.
Fixes #59278.

@SergeyBiryukov commented on PR #5132:


4 months ago
#7

Thanks for the PR! Merged in r57364.

Note: See TracTickets for help on using tickets.