WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#59304 closed enhancement (fixed)

Code quality improvements to `class-wp-theme-json`

Reported by: isabel_brison Owned by: isabel_brison
Priority: normal Milestone: 6.4
Component: Editor Version: 6.4
Severity: normal Keywords: gutenberg-merge has-patch
Cc: Focuses:

Description

This ticket tracks syncing the enhancements from the following Gutenberg PRs:

​https://github.com/WordPress/gutenberg/pull/53568
​https://github.com/WordPress/gutenberg/pull/53574

Change History (3)

This ticket was mentioned in ​PR #5162 on ​WordPress/wordpress-develop by ​@isabel_brison.
3 years ago #1

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/59304

Syncs the following changes from Gutenberg:

​https://github.com/WordPress/gutenberg/pull/53568
​https://github.com/WordPress/gutenberg/pull/53574

Test by checking that preset classnames and variables are correctly output in the front end, and making sure unit tests pass.

#2 @isabel_brison
3 years ago

  • Owner set to isabel_brison
  • Resolution → fixed
  • Status new → closed

In 56545:

Editor: performance enhancements to class-wp-theme-json.

Removes unnecessary sanitisation of hardcoded strings and avoids looping over style presets without classes or variables.

Props flixos90.
Fixes #59304.

​@isabel_brison commented on ​PR #5162:
3 years ago #3

Committed in r56545.

Note: See TracTickets for help on using tickets.