#59305 closed enhancement (fixed)
Make wp_block action notices reference patterns instead of blocks
| Reported by: | aaronrobertshaw | Owned by: | isabel_brison |
|---|---|---|---|
| Priority: | normal | Milestone: | 6.4 |
| Component: | Posts, Post Types | Version: | |
| Severity: | minor | Keywords: | has-patch commit |
| Cc: | Focuses: |
Description
First reported in https://github.com/WordPress/gutenberg/issues/53370
Now that reusable blocks have been renamed to patterns, it doesn't make sense to reference blocks in the wp_block action notices, e.g. "1 block moved to the Trash".
Instead, these notices should read something like: "1 pattern moved to the Trash."
Step-by-step reproduction instructions:
- Add a new pattern via
wp-admin/post-new.php?post_type=wp_block - Navigate back to the Patterns wp-admin page:
wp-admin/edit.php?post_type=wp_block - Perform actions such as deleting or restoring the new pattern
- Note the notices refer to a "block"
Change History (9)
This ticket was mentioned in PR #5163 on WordPress/wordpress-develop by @aaronrobertshaw.
3 years ago
#1
- Keywords has-patch added
@mukesh27 commented on PR #5163:
3 years ago
#2
@aaronrobertshaw Is this PR part of 6.4?
@aaronrobertshaw commented on PR #5163:
3 years ago
#3
Thanks for reviewing @mukeshpanchal27 👍
Is this PR part of 6.4?
Reusable blocks were renamed to patterns in 6.3 so this would be good to land in 6.4.
#5
@
3 years ago
@mukesh27 are we good to go with this ticket? I wonder if we need to add (sync patterns) into docs when we have reusable blocks as well, because it is getting a bit confusing, but it can be done separately if needed :)
#6
@
3 years ago
- Keywords commit added
@oglekler, yes, please open a new ticket. However, before it gets into the core, it should be merged into the GB (Gutenberg) repository, and then it can be backported.
@isabel_brison, could you kindly review and commit this? The changes are straightforward.
#7
@
3 years ago
@mukesh27, FWIW, I couldn't see any references to these action notices in Gutenberg, only in core. I believe this is why the notices weren't updated when reusable blocks were first renamed to patterns.
So that said, I don't think there will be a Gutenberg PR to merge first unless I'm missing something.
Update: Nevermind me, I misunderstood the last comment :)
@isabel_brison commented on PR #5163:
3 years ago
#9
Committed in r56606.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Update the wp-admin notices when performing actions on the
wp_blockpost type to refer to patterns now that reusable blocks have been renamed to patterns.First reported in https://github.com/WordPress/gutenberg/issues/53370.
Test instructions:
wp-admin/post-new.php?post_type=wp_blockwp-admin/edit.php?post_type=wp_blockTrac ticket: https://core.trac.wordpress.org/ticket/59305