Make WordPress Core

Opened 3 months ago

Closed 3 months ago

Last modified 3 months ago

#59306 closed enhancement (fixed)

Add writing-mode as a typography block support

Reported by: poena's profile poena Owned by: isabel_brison's profile isabel_brison
Milestone: 6.4 Priority: normal
Severity: normal Version: 6.4
Component: Editor Keywords: gutenberg-merge has-patch
Focuses: Cc:

Description

This ticket is for tracking the PHP backport for the following Gutenberg PR:
https://github.com/WordPress/gutenberg/pull/50822

Attachments (1)

writing-mode.diff (4.7 KB) - added by poena 3 months ago.
Add writing-mode typography block support

Download all attachments as: .zip

Change History (6)

@poena
3 months ago

Add writing-mode typography block support

#1 @poena
3 months ago

  • Keywords has-patch added

This ticket was mentioned in PR #5210 on WordPress/wordpress-develop by @isabel_brison.


3 months ago
#2

Trac ticket: https://core.trac.wordpress.org/ticket/59306

Just doing a quick PR from the patch on the ticket to run CI on it (and also because I find the GH diff easier to read 😄)

#3 @isabel_brison
3 months ago

Changes LGTM; there was a linting error which I fixed in the attached PR: https://github.com/WordPress/wordpress-develop/pull/5210

I was wondering if we should add a test for this feature in the typography test suite: https://github.com/WordPress/wordpress-develop/blob/trunk/tests/phpunit/tests/block-supports/typography.php but we're not being consistent with tests for other discreet features such as letter-spacing or text-decoration so I guess we could leave this as is and revisit those tests later as a whole.

#4 @isabel_brison
3 months ago

  • Owner set to isabel_brison
  • Resolution set to fixed
  • Status changed from new to closed

In 56605:

Editor: add text orientation for blocks with typography support.

Adds a new text orientation option to the typography block support, implemented with CSS writing-mode.

Props poena.
Fixes #59306.

@isabel_brison commented on PR #5210:


3 months ago
#5

committed in r56605.

Note: See TracTickets for help on using tickets.