Make WordPress Core

Opened 10 months ago

Closed 9 months ago

Last modified 9 months ago

#59309 closed enhancement (fixed)

Add block instance element color support for buttons and headings

Reported by: aaronrobertshaw's profile aaronrobertshaw Owned by: isabel_brison's profile isabel_brison
Milestone: 6.4 Priority: normal
Severity: normal Version: 6.4
Component: Editor Keywords: gutenberg-merge has-patch has-unit-tests
Focuses: Cc:

Description

This ticket tracks the backporting of PHP files for the following Gutenberg changes:

https://github.com/WordPress/gutenberg/pull/53667

These changes provide the ability to specify colors for button and heading elements within a block instance, such as an individual group block.

Change History (5)

This ticket was mentioned in PR #5164 on WordPress/wordpress-develop by @aaronrobertshaw.


10 months ago
#1

  • Keywords has-patch has-unit-tests added

This is a backport PR for WordPress 6.4 that includes the following PHP Gutenberg changes:

It also adds a couple of unit tests to cover the application of the wp-elements-* classname for buttons and headings.

Trac ticket: https://core.trac.wordpress.org/ticket/59309

@aaronrobertshaw commented on PR #5164:


9 months ago
#2

Thanks for the review @tellthemachines 👍

I suppose it's not worth adding a test for wp_render_elements_support_styles given that it doesn't return anything significant.

I was in two minds about this, on one hand it would be good to confirm that elements styles are generated appropriately, on the other hand it's really just testing the style engine. Ultimately, my reasoning in omitting it was as you suggested, it doesn't really return anything of note.

#3 @isabel_brison
9 months ago

  • Owner set to isabel_brison
  • Resolution set to fixed
  • Status changed from new to closed

In 56604:

Editor: add block instance element color support for buttons and headings.

Adds support for buttons and headings to the colors and elements block supports, allowing button and heading element colors to be changed on individual blocks.

Props aaronrobertshaw.
Fixes #59309.

@isabel_brison commented on PR #5164:


9 months ago
#4

Committed in r56604.

#5 @isabel_brison
9 months ago

  • Milestone changed from Awaiting Review to 6.4
Note: See TracTickets for help on using tickets.