Changes between Initial Version and Version 2 of Ticket #59331
- Timestamp:
- 09/12/2023 09:45:19 PM (2 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #59331 – Description
initial v2 1 A user [https://mastodon.social/@grigs@front-end.social/111052735378137214 reported] hero images were getting `loading=lazy` on their site. After inquiring, I found they were using Timber for templating. It makes sense that the logic in `wp_get_loading_optimization_attributes()` wouldn't work properly in this case since it is tightly bound to WordPress's templating system(s). This may actually be an issue better fixed in Timber itself, but ideally WordPress core should be able to do the right thing with alternate templating systems (or even complex templates written in the WordPress way). Ultimately, this may require the use of output buffering and HTML Tag Processor as [https://github.com/WordPress/performance/issues/805 proposed] for a module in the Performance Lab plugin. 1 A user [https://mastodon.social/@grigs@front-end.social/111052735378137214 reported] hero images were getting `loading=lazy` on their site. After inquiring, I found they were using Timber for templating. It makes sense that the logic in `wp_get_loading_optimization_attributes()` wouldn't work properly in this case since it is tightly bound to WordPress's templating system(s). This may actually be an issue better fixed in Timber itself, but ideally WordPress core should be able to do the right thing with alternate templating systems (or even complex templates written in the WordPress way). Ultimately, this may require the use of output buffering and HTML Tag Processor as [https://github.com/WordPress/performance/issues/805 proposed] for a module in the Performance Lab plugin. See #59331 for adding output buffering for template renders with a filter for post-processing. 2 2 3 3 Here's how to reproduce the issue with Timber: