Opened 12 months ago
#59361 new defect (bug)
update_post_meta() strict checks can cause false negatives
Reported by: | mukesh27 | Owned by: | |
---|---|---|---|
Milestone: | Future Release | Priority: | normal |
Severity: | normal | Version: | |
Component: | Options, Meta APIs | Keywords: | needs-patch needs-unit-tests |
Focuses: | performance | Cc: |
Description
Follow up: #22192
add_post_meta( $post_id, 'key', 1 ); update_post_meta( $post_id, 'key', 1 );
The update should not work, because they are the same. However, the meta meta cache will have "1" as a string, and then it will strict compare it to 1 as an integer. Thus, an unnecessary update will run.
It is quite common to use integers and booleans directly into these functions. They should be smart enough to recognize that "1" == 1 == true and "0" == 0 == false, and that any numeric string is also equal to a properly cast integer.
The new changes need unit tests.
Ticket from which this was spun: #22189, saving navigation menus is slow.
cc. @flixos90 @spacedmonkey @joemcgill
Note: See
TracTickets for help on using
tickets.