Make WordPress Core

Opened 18 years ago

Closed 18 years ago

#5937 closed defect (bug) (invalid)

Thickbox implementation conflict

Reported by: alexrabe's profile alexrabe Owned by: ryan's profile ryan
Milestone: Priority: normal
Severity: normal Version: 2.5
Component: General Keywords: Thickbox, jQuery
Focuses: Cc:

Description

The new image uploader in #5609 uses a modified Thickbox version :

"I made some wp-specific changes to the Thickbox js: $() changed to jQuery(); addLoadEvent() instead of read() (thanks mdawaffe); and the close link changed to a [x] png as per the design spec."

Plugins (like NextGEN Gallery) also uses often the Thickbox effect to show larger popup images. Due to the fact that I uses the script loader with wp_enqueue_script('thickbox'... the wp-specific version gets loaded in the frontend and failed due to the fact that addLoadEvent() didn't exist.

Solution could be :

a) Rename the wp-specific version in the script-loader to "WP-Thickbox" or whatever
b) Move addLoadEvent() outside of the thickbox script
c) All plugins must deregister "Thickbox" and add the offical one, which could then affected the Image uploader in the backend...

Change History (4)

#1 @ryan
18 years ago

  • Owner changed from anonymous to ryan

#2 @alexrabe
18 years ago

  • Resolution set to wontfix
  • Status changed from new to closed

Could be the same answer like #6050, I will change my thickbox script name, to avoid loading of Wp Thickbox. Thanks.

#3 @lloydbudd
18 years ago

  • Milestone 2.5 deleted
  • Resolution wontfix deleted
  • Status changed from closed to reopened

#4 @lloydbudd
18 years ago

  • Resolution set to invalid
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.