#59387 closed defect (bug) (fixed)
Add writing-mode as an allowed attribute to safecss_filter_attr()
| Reported by: | wildworks | Owned by: | SergeyBiryukov |
|---|---|---|---|
| Priority: | normal | Milestone: | 6.4 |
| Component: | Formatting | Version: | |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: |
Description
#59306 added writing-mode to the typography support. However, this property is not allowed by safecss_filter_attr() function, so this property will be removed when outputting inline styles with the get_block_wrapper_attributes() function, for example.
This ticket is for tracking the PHP backport for the following Gutenberg PR: https://github.com/WordPress/gutenberg/pull/54581
Attachments (2)
Change History (9)
#4
@
3 years ago
I submitted patch-1.diff with added @since annotation.
There was a typo in the comment text of the phpunit test, so I fixed it at the same time (// Wiritng mode introduced in 6.4. > // Writing mode introduced in 6.4.).
#5
@
3 years ago
- Component General → Formatting
- Keywords needs-refresh removed
- Owner set to
- Status new → accepted
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
@wildworks thanks for ticket and patch.
Could you please document
sinceannotation for the function?