#59387 closed defect (bug) (fixed)
Add writing-mode as an allowed attribute to safecss_filter_attr()
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 6.4 | Priority: | normal |
| Severity: | normal | Version: | |
| Component: | Formatting | Keywords: | has-patch |
| Focuses: | Cc: |
Description
#59306 added writing-mode to the typography support. However, this property is not allowed by safecss_filter_attr() function, so this property will be removed when outputting inline styles with the get_block_wrapper_attributes() function, for example.
This ticket is for tracking the PHP backport for the following Gutenberg PR: https://github.com/WordPress/gutenberg/pull/54581
Attachments (2)
Change History (9)
#4
@
3 years ago
I submitted patch-1.diff with added @since annotation.
There was a typo in the comment text of the phpunit test, so I fixed it at the same time (// Wiritng mode introduced in 6.4. > // Writing mode introduced in 6.4.).
#5
@
3 years ago
- Component changed from General to Formatting
- Keywords needs-refresh removed
- Owner set to SergeyBiryukov
- Status changed from new to accepted
This ticket was mentioned in Slack in #core by youknowriad. View the logs.
2 years ago
Note: See
TracTickets for help on using
tickets.
@wildworks thanks for ticket and patch.
Could you please document
sinceannotation for the function?