Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#59389 closed enhancement (fixed)

Coding Standards: Use `implode` instead of `join` in tests/phpunit/tests/media.php and tests/phpunit/tests/media/getPostGalleries.php

Reported by: david.binda Owned by: costdev
Priority: normal Milestone: 6.4
Component: General Version: 5.9
Severity: normal Keywords: has-patch commit
Cc: Focuses: coding-standards

Description

r49193 replaced multiple instances of aliased functions by the canonical ones. Since then, some new instances of join instead of implode were introduced.

Attachments (1)

59389.diff​ (3.2 KB ) - added by david.binda 3 years ago.

Download all attachments as: .zip

Change History (5)

#1 @mukesh27
3 years ago

  • Keywords has-patch commit added
  • Milestone Awaiting Review → 6.4

Thanks @davidbinda for ticket and patch.

Patch tested on local and working fine. mark as commit consideration.

@costdev could you please take a look.

#2 @costdev
3 years ago

  • Owner set to costdev
  • Status new → assigned

Thanks for the ticket @david.binda and for the ping @mukesh27!

59389.diff looks good!

Self-assigning for commit.

Last edited 3 years ago by costdev (previous) (diff)

#3 @costdev
3 years ago

  • Resolution → fixed
  • Status assigned → closed

In 56616:

Coding Standards: Replace PHP alias join() with implode().

In [52190], some new instances of the join() alias were introduced in the test suite.

Using the canonical function name for PHP functions is strongly recommended, as aliases may be deprecated or removed without (much) warning.

This replaces the new join() uses with the canonical implode() function name.

Follow-up to [46182], [49193], [49805], [52190].

Props david.binda, mukesh27.
Fixes #59389.

#4 @costdev
3 years ago

  • Version → 5.9
Note: See TracTickets for help on using tickets.