WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#59393 closed enhancement (fixed)

Image: Add the lightbox setting to theme.json

Reported by: czapla Owned by: isabel_brison
Priority: normal Milestone: 6.4
Component: Editor Version:
Severity: normal Keywords: gutenberg-merge has-patch
Cc: Focuses:

Description

This ticket tracks the backporting of PHP files for the following Gutenberg changes:

Change History (7)

This ticket was mentioned in ​PR #5248 on ​WordPress/wordpress-develop by ​@czapla.
3 years ago #1

  • Keywords has-patch added

This is a backport PR for WordPress 6.4 that includes the following PHP Gutenberg changes:

#2 @costdev
3 years ago

  • Milestone Awaiting Review → 6.4

#3 @desrosj
3 years ago

#59392 was marked as a duplicate.

​@isabel_brison commented on ​PR #5248:
3 years ago #4

Added the theme.json change and rebased the branch to see if tests pass.

#5 @isabel_brison
3 years ago

  • Owner set to isabel_brison
  • Resolution → fixed
  • Status new → closed

In 56643:

Editor: add lightbox setting.

Adds lightbox as a valid setting to WP_Theme_JSON class and as an image block setting in theme.json.

Props czapla, costdev, desrosj.
Fixes #59393.

​@isabel_brison commented on ​PR #5248:
3 years ago #6

Committed in r56643.

​@czapla commented on ​PR #5248:
3 years ago #7

Thanks for the PR! The changes from lib/theme.json in the linked Gutenberg PR should also be added to the​core theme.json file.

Thanks for following up on this @tellthemachines and sorry I didn't get to it yesterday! 😊

Note: See TracTickets for help on using tickets.