Fix failing unit tests

[desrosj]

PHPUnit x.y.z was released earlier today with a change that addresses a ​breaking change upstream from PHP.

This causes two failures in the Core test suite:

There were 2 failures:

1) Tests_Admin_WpAutomaticUpdater::test_is_allowed_dir_should_return_true_if_open_basedir_is_set_and_path_is_allowed
Test was run in child process and ended unexpectedly

phpvfscomposer:///var/www/vendor/phpunit/phpunit/phpunit:97
/var/www/vendor/bin/phpunit:118

2) Tests_Admin_WpAutomaticUpdater::test_is_allowed_dir_should_return_false_if_open_basedir_is_set_and_path_is_not_allowed
Test was run in child process and ended unexpectedly

phpvfscomposer:///var/www/vendor/phpunit/phpunit/phpunit:97
/var/www/vendor/bin/phpunit:118

Three versions of PHPUnit were released. Any changes made to fix these failing tests will need to be backported to any branch that uses:

• ​PHPUnit 10.3.5
• ​PHPUnit 9.6.13
• ​PHPUnit 8.5.34

Props @mukesh27 for ​the original report.

In PHPUnit 9.6.13, the child processes used for process isolation now use temporary files to communicate their result to the parent process. This caused a failure in some tests that set the open_basedir PHP directive.

This adds sys_get_temp_dir() to the open_basedir value set by the tests.

References:

• ​https://github.com/sebastianbergmann/phpunit/issues/5356

[costdev]

The failing tests were introduced in [55425] / #42619, so backports should only need to go as far as the 6.2 branch.

[costdev]

I tested this on Linux and @SergeyBiryukov tested this on Windows. Tests were successful.

​PR 5249 has been reviewed and approved.

Adding for commit and prepping this now.

[costdev]

In 56622:

Build/Test Tools: Add sys_get_temp_dir() to open_basedir tests.

In PHPUnit 10.3.5, 9.6.13 and 8.5.34, the child processes used for process isolation now use temporary files to communicate their result to the parent process.

This caused a failure in some tests that set the open_basedir PHP directive to a value that did not include sys_get_temp_dir().

This adds sys_get_temp_dir() to the open_basedir value set by the tests to ensure that permission is still granted for the temporary directory.

PHPUnit uses sys_get_temp_dir(). To ensure the result is the same, Core's get_temp_dir() function is not used.

References:

• ​https://github.com/sebastianbergmann/phpunit/issues/5356

Props desrosj, mukesh27, SergeyBiryukov, costdev.
Fixes #59394.

Committed in r56622.

[costdev]

Reopening for backport to the 6.2 and 6.3 branches.

[costdev]

In 56624:

Build/Test Tools: Add sys_get_temp_dir() to open_basedir tests.

In PHPUnit 10.3.5, 9.6.13 and 8.5.34, the child processes used for process isolation now use temporary files to communicate their result to the parent process.

This caused a failure in some tests that set the open_basedir PHP directive to a value that did not include sys_get_temp_dir().

This adds sys_get_temp_dir() to the open_basedir value set by the tests to ensure that permission is still granted for the temporary directory.

PHPUnit uses sys_get_temp_dir(). To ensure the result is the same, Core's get_temp_dir() function is not used.

References:

• ​https://github.com/sebastianbergmann/phpunit/issues/5356

Props desrosj, mukesh27, SergeyBiryukov, costdev.
Merges [56622] to the 6.3 branch.
See #59394.

[costdev]

In 56625:

Build/Test Tools: Add sys_get_temp_dir() to open_basedir tests.

In PHPUnit 10.3.5, 9.6.13 and 8.5.34, the child processes used for process isolation now use temporary files to communicate their result to the parent process.

This caused a failure in some tests that set the open_basedir PHP directive to a value that did not include sys_get_temp_dir().

This adds sys_get_temp_dir() to the open_basedir value set by the tests to ensure that permission is still granted for the temporary directory.

PHPUnit uses sys_get_temp_dir(). To ensure the result is the same, Core's get_temp_dir() function is not used.

References:

• ​https://github.com/sebastianbergmann/phpunit/issues/5356

Props desrosj, mukesh27, SergeyBiryukov, costdev.
Merges [56622] to the 6.2 branch.
See #59394.

[costdev]

Backports to the 6.2 and 6.3 branches are complete. Closing the ticket. Thanks everyone!